Bug 474841 - Add External Subtitle dialogue should start in video directory, not home directory
Summary: Add External Subtitle dialogue should start in video directory, not home dire...
Status: RESOLVED FIXED
Alias: None
Product: Haruna
Classification: Applications
Component: generic (show other bugs)
Version: 0.12.1
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: george fb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-24 22:38 UTC by Dick Tracey
Modified: 2023-11-12 09:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dick Tracey 2023-09-24 22:38:05 UTC
SUMMARY
***
Currently, when you click on Add External Subtitle, the file selector starts at your home directory, which is almost never what users want, and doesn't match the behavior of the more popular/main stream players.
The file selector should instead start at the directory which contains the video, because that's where the subtitles would like be around.
***


STEPS TO REPRODUCE
1. Click Subtitles > Add External Subtitle
2. 
3. 

OBSERVED RESULT
File selector starts from home

EXPECTED RESULT
File selector starts from the directory containing the currently played video


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 george fb 2023-10-18 21:18:40 UTC
It already does that.
Comment 2 Dick Tracey 2023-10-25 17:09:36 UTC
No, it doesn't. Whenever you start a new instance of haruna, the Add Subtitle dialog starts at user's home directory.

Using 0.12.1 on Arch Linux.
Comment 3 Bug Janitor Service 2023-11-09 03:45:59 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 george fb 2023-11-12 09:09:27 UTC
Git commit f80ee5f011eab50772528c41b8634aa3523e738b by George Florea Bănuș.
Committed on 12/11/2023 at 10:09.
Pushed by georgefb into branch 'master'.

subtitlesFileDialog: use mpv.currentUrl to set the dialog's location

M  +4    -3    src/qml/main.qml

https://invent.kde.org/multimedia/haruna/-/commit/f80ee5f011eab50772528c41b8634aa3523e738b