Bug 474759 - The tool to align the category of operations with their payees' always fills in the category of the first payee it found
Summary: The tool to align the category of operations with their payees' always fills ...
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 08:23 UTC by riaasm
Modified: 2023-10-01 20:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description riaasm 2023-09-21 08:23:15 UTC
SUMMARY
The tool to align the category of operations with their payees' always fills in the category of the first payee it found.

STEPS TO REPRODUCE
1. Have some payees with multiple different categories filled in
2. Have some operations without category filled in with payees that have different categories
3. Click on "Tools > Align the category of all single operations with the category of their payee"

OBSERVED RESULT
For any operation that matches a payee, the category filled in is the category of the first payee found. 

EXPECTED RESULT
For any operation that matches a payee, the category filled in is the category of its own payee. 

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  Skrooge version 2.30.0
(available in About System)
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION
This feature was introduced in commit 22a25c542f2502929a2cdc56d400763c2c18262d

The problem seems to be that the category of the first payee is remembered somehow. This even happens when you trigger the feature multiple times independently. The alternative reproduction for that is as follows:
1. Have some payees with multiple different categories filled in
2. Have some operations without category filled in with payees that have different categories
3. Select one such operation
4. Click on "Tools > Align the category of all selected single operations with the category of their payee" (the name of the menu item changes slightly when operations are selected)
5. The category of the operation is correctly updated with the category of the payee
6. Select another operation, one with a payee that has a different category than the previous one
7. Click on "Tools > Align the category of all selected single operations with the category of their payee" again
8. The category of the operation is set to the category of the first selected operation's payee, not this operation's payee.
9. You repeat steps 6-8 but it will always set the category to the first selected operation's payee.
Comment 1 Stephane MANKOWSKI 2023-10-01 20:12:41 UTC
Git commit a5edb0108d77768cf771689ecb34ba4c2fac309a by Stephane MANKOWSKI.
Committed on 01/10/2023 at 22:12.
Pushed by smankowski into branch 'master'.

The tool to align the category of operations with their payees' always fills in the category of the first payee it found

M  +3    -3    plugins/skrooge/skrooge_operation/skgoperationplugin.cpp
M  +1    -1    plugins/skrooge/skrooge_operation/skgoperationplugin.h

https://invent.kde.org/office/skrooge/-/commit/a5edb0108d77768cf771689ecb34ba4c2fac309a