Bug 474631 - ModemManager-Qt hits asserts if ModemManager has errors starting up and exporting objects to bus
Summary: ModemManager-Qt hits asserts if ModemManager has errors starting up and expor...
Status: REPORTED
Alias: None
Product: frameworks-modemmanager-qt
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-17 19:14 UTC by Janet Blackquill
Modified: 2023-09-17 21:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Janet Blackquill 2023-09-17 19:14:30 UTC
mmqt hits an assert in modemdevice.cpp around here:
```
    bool success = QDBusConnection::systemBus().connect(QLatin1String(MMQT_DBUS_SERVICE),
                                         QLatin1String(MMQT_DBUS_PATH),
                                         QLatin1String(DBUS_INTERFACE_MANAGER),
                                         QStringLiteral("InterfacesAdded"),
                                         this,
                                         SLOT(onInterfacesAdded(QDBusObjectPath, ModemManager::MMVariantMapMap)));
    Q_ASSERT(success);
```

OBSERVED RESULT
mmqt assumes that modemmanager is always functional

EXPECTED RESULT
mmqt gracefully handles modemmanager failing to initialise due to e.g. hardware issues

ADDITIONAL INFORMATION
this causes downstream issues in kded and plasmashell, which causes much of the plasma session to become unfunctional due to code calling into mmqt
Comment 1 David Edmundson 2023-09-17 21:43:35 UTC
>mmqt gracefully handles modemmanager failing to initialise due to e.g. hardware issues

That wouldn't cause this assert. We're blindly connecting a match rule to a slot. Nothing remote matters at all.
Comment 2 David Edmundson 2023-09-17 21:45:06 UTC Comment hidden (spam)