Bug 474580 - Sidebar items do not stay highlighted any more
Summary: Sidebar items do not stay highlighted any more
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-09-15 22:33 UTC by Jack Hill
Modified: 2023-10-13 14:49 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/multimedia/elisa/-/commit/f909a9b9748be0eecf73fcab7ce7362bdd1f9290
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-09-15 22:33:32 UTC 
SUMMARY

STEPS TO REPRODUCE
1. Click an item in the sidebar

OBSERVED RESULT
Sidebar item is highlighted for a very short time, then loses the highlight

EXPECTED RESULT
Sidebar item should stay highlighted

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230911
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.110.0
Qt Version: 5.15.10
Kernel Version: 6.5.2-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Nicolas Fella 2023-09-16 10:39:58 UTC 
> Qt Version: 5.15.10

Please specify the correct Qt6 version here when reporting bugs for Qt6 builds
Comment 2 Jack Hill 2023-09-17 09:45:47 UTC 
Qt version is 6.5.2 from openSUSE repos
Comment 3 Nate Graham 2023-09-19 19:55:37 UTC 
Can reproduce.
Comment 4 Nate Graham 2023-10-05 18:31:49 UTC 
Git commit 6ba61af9d7342cc7c1d71d1363548ceab6e0fed3 by Nate Graham.
Committed on 05/10/2023 at 20:31.
Pushed by ngraham into branch 'master'.

Fix missing sidebar highlight

M  +1    -0    src/qml/ViewSelector.qml

https://invent.kde.org/multimedia/elisa/-/commit/6ba61af9d7342cc7c1d71d1363548ceab6e0fed3
Comment 5 Nate Graham 2023-10-13 14:49:53 UTC 
Git commit f909a9b9748be0eecf73fcab7ce7362bdd1f9290 by Nate Graham.
Committed on 13/10/2023 at 16:44.
Pushed by ngraham into branch 'master'.

Port away from old Kirigami List Items

Instead use ItemDelegates and such.

M  +7    -5    src/qml/PlayListEntry.qml
M  +3    -7    src/qml/ViewSelector.qml
M  +1    -1    src/qml/mobile/MobilePlayListDelegate.qml
M  +2    -1    src/qml/shared/BasePlayListDelegate.qml

https://invent.kde.org/multimedia/elisa/-/commit/f909a9b9748be0eecf73fcab7ce7362bdd1f9290