Bug 474418 - Add Numista# search
Summary: Add Numista# search
Status: RESOLVED WORKSFORME
Alias: None
Product: tellico
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-11 17:24 UTC by Robby Stephenson
Modified: 2023-09-28 13:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Stephenson 2023-09-11 17:24:12 UTC
From https://mail.kde.org/pipermail/tellico-users/2023-September/001842.html

I checked in recently and found that Tellico now has a Numista data source. This is great! However, it seems that the Numista search method Tellico uses does not use Numista's N#'s. This is a unique number assigned to everything on Numista.  There are also NN#'s for subtypes.

I have tried repeatedly with multiple different search terms, but I have yet to be able to use the Numista search in Tellico to find a 2 US Dollar note. I was able to browse to it on the Numista website. So I have the URL (https://en.numista.com/catalogue/note201812.html), the N# (N# 201812; also in the URL), the description... but I cannot get it into Tellico bc Numista's search is so horrible.  (by the way, the search results seem to be limited to 20 items)

IDEALLY, I'd hope to be able to use Tellico to do a straight lookup by both
1) URL of the item, which contains type (banknote, coin, exonumia) and N# in it (this will be important later)
2) The N# or NN# directly

Per the API docs (https://en.numista.com/api/doc/index.php) it seems that N# lookups are straightforward, you just need to know the type:  https://api.numista.com/api/v3/coins/95420
Because of that, the Tellico Numista search dropdown might need to add "Coin N#", "Banknote N#", and "Exonumia N#" options.
Comment 1 Robby Stephenson 2023-09-20 00:59:36 UTC
Git commit 58037ed0320c7447dc10c8165ba7296c2b5d6e72 by Robby Stephenson.
Committed on 20/09/2023 at 02:59.
Pushed by rstephenson into branch '3.5'.

Allow fetching more than 20 results from Numista when available

M  +4    -0    ChangeLog
M  +4    -2    src/fetch/numistafetcher.cpp
M  +12   -0    src/tests/numistafetchertest.cpp
M  +1    -0    src/tests/numistafetchertest.h

https://invent.kde.org/office/tellico/-/commit/58037ed0320c7447dc10c8165ba7296c2b5d6e72
Comment 2 Robby Stephenson 2023-09-20 01:00:42 UTC
Git commit bfef4c196850b6dffdca19f98d1e2c3e3a77dfac by Robby Stephenson.
Committed on 20/09/2023 at 02:55.
Pushed by rstephenson into branch 'master'.

Allow fetching more than 20 results form Numista when available

M  +4    -0    ChangeLog
M  +4    -2    src/fetch/numistafetcher.cpp
M  +12   -0    src/tests/numistafetchertest.cpp
M  +1    -0    src/tests/numistafetchertest.h

https://invent.kde.org/office/tellico/-/commit/bfef4c196850b6dffdca19f98d1e2c3e3a77dfac
Comment 3 Robby Stephenson 2023-09-28 13:40:47 UTC
Closing this bug since N# searching does work for coins. A new wishlist item will be opened to track updating Tellico for banknotes searching, in general