Bug 474317 - Make default annotation mode configurable
Summary: Make default annotation mode configurable
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: Viewer (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-08 23:53 UTC by Johannes Zarl-Zierl
Modified: 2026-01-26 22:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Zarl-Zierl 2023-09-08 23:53:50 UTC
The new annotation feature of the viewer dialog starts in "no annotations" mode and has to be explicitly toggled to "Annotate" or "Add Tokens" mode.

To quote Andreas in bug #474307:

> Unfortunately, the change (crtl-T) is not permanent, which is what I would prefer.
> [...]
> "Let me chose the default setting somewhere in the viewer settings." 
> This would also have the benefit to move this hidden feature a bit more to the front.
Comment 1 Johannes Zarl-Zierl 2023-09-08 23:56:59 UTC
@Andreas: I've added you to the CC list for this wishlist item.
Comment 2 Andreas Schleth 2023-09-10 21:54:19 UTC
Thanks, and kudos for keeping the docs AHEAD of the release. I've never seen this before :-)
Comment 3 rlk 2023-12-05 01:32:27 UTC
Second here -- assigning tokens is extremely useful in the viewer (to me, at any rate), and I'm not interested in annotating through the viewer.  Being able to set this once would make life easier.
Comment 4 Johannes Zarl-Zierl 2026-01-25 16:03:16 UTC
Git commit d9c690298a97a59dc4db0411b3c0aa3f3e7366a6 by Johannes Zarl-Zierl.
Committed on 25/01/2026 at 15:51.
Pushed by johanneszarl into branch 'master'.

Viewer: Make default tag mode configurable

This commit adds the GUI elements to actually configure the default tag
mode for the viewer, which was introduced by the previous commit
b8164621b.

M  +9    -0    Settings/ViewerPage.cpp
M  +1    -0    Settings/ViewerPage.h

https://invent.kde.org/graphics/kphotoalbum/-/commit/d9c690298a97a59dc4db0411b3c0aa3f3e7366a6
Comment 5 Andreas Schleth 2026-01-25 16:20:35 UTC
Works as expected.
Very nice. Thanks!
Comment 6 rlk 2026-01-25 17:43:04 UTC
I suggest that if the mode is locked, and the user tries to do something, that a box pop up (at least the first time it's done on any particular viewer) noting that it's doing nothing.
Comment 7 Johannes Zarl-Zierl 2026-01-25 21:23:56 UTC
Robert: Having some feedback when *nothing* is done feels quite strange, and probably will mess with everyone who is using the viewer as "just" a quick image viewer. Especially since there is a visual confirmation when adding tags or tokens.
Comment 8 rlk 2026-01-26 01:39:44 UTC
People used to earlier versions of kpa, where typing a letter applied a token and there was no visual feedback other than via the EXIF viewer will lose work without the feedback.  The feedback itself is subtle.  Perhaps similar feedback when it's locked (a banner that says "locked, nothing was done").

My cameras have a lock mode to protect against inadvertently changing controls (it's very easy to inadvertently turn one of the dials, changing the exposure when you don't want to).  If I try to turn one of the dials when it's locked, it quickly pops up a message that the controls are locked.
Comment 9 Johannes Zarl-Zierl 2026-01-26 22:57:59 UTC
Git commit d125005262f15055f126be662471a5c5760c34f9 by Johannes Zarl-Zierl.
Committed on 26/01/2026 at 22:39.
Pushed by johanneszarl into branch 'master'.

Viewer: add feedback when locked

This is a try to accomodate users expecting the pre v5.12 behaviour of
key presses from a-z assigning tokens without feedback (besides the
infobox).

M  +7    -4    Viewer/ViewerWidget.cpp

https://invent.kde.org/graphics/kphotoalbum/-/commit/d125005262f15055f126be662471a5c5760c34f9
Comment 10 Johannes Zarl-Zierl 2026-01-26 22:58:50 UTC
Let's try it and see if users complain the other way round ;-)