Bug 474292 - tarme does not detect currently used path on download.kde.org
Summary: tarme does not detect currently used path on download.kde.org
Status: RESOLVED FIXED
Alias: None
Product: releaseme
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-08 10:58 UTC by Ralf Habacker
Modified: 2024-08-19 11:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2023-09-08 10:58:33 UTC
SUMMARY
tarme generates a sysadmin request link at the end of tarball generation, specifying the path to the files to be released.    
... 

Please add x.y.z to bugs.kde.org product yyy

Target: stable/yyy


There are currently two variants for this path:
1. a subdirectory with the current version, e.g. https://download.kde.org/stable/kio-fuse/
2. without a subdirectory, e.g. https://download.kde.org/stable/arianna/ 

tarme currently cannot automatically detect this detail and always uses variant 2. which may be incorrect.
To set this path correctly, a manual determination of the used path scheme is necessary.

STEPS TO REPRODUCE
1. run tarme on a package to release for the product 'alkimia' and version 8.1.2 
2. inspect the generated url 

OBSERVED RESULT
In the generated sysadmin request there is 

Target: stable/alkimia

EXPECTED RESULT
where it should be

Target: stable/alkimia/8.1.2

SOFTWARE/OS VERSIONS
Linux: openSUSE_Tumbleweed 

ADDITIONAL INFORMATION
Comment 1 Ralf Habacker 2024-03-07 18:37:08 UTC
Git commit 0d9ec20dd44c4b1d6027b29fc9c24f4c6c897117 by Ralf Habacker.
Committed on 07/03/2024 at 18:35.
Pushed by habacker into branch 'master'.

Add note to choose correct target path

M  +6    -0    lib/releaseme/data/ticket_description.txt.erb [INFRASTRUCTURE]

https://invent.kde.org/sdk/releaseme/-/commit/0d9ec20dd44c4b1d6027b29fc9c24f4c6c897117
Comment 2 Ralf Habacker 2024-08-14 16:23:42 UTC
One remaining issue on this topic is that when tarballs are created for the master branch with `--origin trunk`, the created note

 Please add 8.1.74 to bugs.kde.org product alkimia
 NOTE: PLEASE CHOOSE THE CORRECT TARGET AND REMOVE THE OTHER - either "version based style"
 Target: trunk/alkimia/8.1.74
 NOTE: OR "flat style" - see https://download.kde.org/trunk/alkimia for current state
 Target: trunk/alkimia

contains the path `trunk`, while it should be `unstable`.
Comment 3 Bug Janitor Service 2024-08-14 17:04:31 UTC
A possibly relevant merge request was started @ https://invent.kde.org/sdk/releaseme/-/merge_requests/37
Comment 4 Ralf Habacker 2024-08-19 11:23:23 UTC
Git commit d40bb6fb3298ed6faf8b19a9510c28f5a40ea6ff by Ralf Habacker.
Committed on 19/08/2024 at 06:59.
Pushed by habacker into branch 'master'.

Fixed display of a wrong target path in the sysadmin ticket URL generated by tarme.rb

M  +3    -3    lib/releaseme/data/ticket_description.txt.erb [INFRASTRUCTURE]
M  +6    -0    lib/releaseme/origin.rb
M  +1    -1    lib/releaseme/release.rb

https://invent.kde.org/sdk/releaseme/-/commit/d40bb6fb3298ed6faf8b19a9510c28f5a40ea6ff