Bug 474104 - Fetching online quote fails when date was not found
Summary: Fetching online quote fails when date was not found
Status: RESOLVED FIXED
Alias: None
Product: alkimia
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: master
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-03 17:35 UTC by Ralf Habacker
Modified: 2023-09-04 11:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 8.1.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2023-09-03 17:35:01 UTC
SUMMARY
https://invent.kde.org/office/alkimia/-/jobs/1166250 reported an error when the date from the online quote in question cannot be fetched.
 
STEPS TO REPRODUCE
1. Inspect https://invent.kde.org/office/alkimia/-/jobs/1166250

OBSERVED RESULT
The mentioned job shows the following log entry 

QDEBUG : AlkOnlineQuoteTest::testLaunch() Symbol ""
QDEBUG : AlkOnlineQuoteTest::testLaunch() test::AlkQuoteReceiver::slotStatus(  "Symbol found: ''"  )
QDEBUG : AlkOnlineQuoteTest::testLaunch() Price "1.0787"
QDEBUG : AlkOnlineQuoteTest::testLaunch() test::AlkQuoteReceiver::slotStatus(  "Price found: '1.0787' (1.0787)"  )
QDEBUG : AlkOnlineQuoteTest::testLaunch() test::AlkQuoteReceiver::slotError(  "Unable to parse date for 'EUR USD'"  )
QDEBUG : AlkOnlineQuoteTest::testLaunch() test::AlkQuoteReceiver::slotStatus(  "Using current date for 'EUR USD'"  )
FAIL!  : AlkOnlineQuoteTest::testLaunch() 'quote.launch("EUR USD", "EUR USD", source)' returned FALSE. ()

EXPECTED RESULT
This test should not fail

SOFTWARE/OS VERSIONS
Linux: openSUSE 15.4 
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.5

ADDITIONAL INFORMATION
The also available CI jobs named 'xxx_qt515'  shows the same error (see for example https://invent.kde.org/office/alkimia/-/jobs/1166243) but did not report it.
Comment 1 Ralf Habacker 2023-09-03 19:46:18 UTC
Git commit cb65f11bc00a648bcdec57626d2a27b16c027fa8 by Ralf Habacker.
Committed on 03/09/2023 at 21:45.
Pushed by habacker into branch '8.1'.

Fix error when retrieving data when no date was found

This commit fixes a bug that caused a general error when
retrieving an online source if no date was found when
parsing the quote.
FIXED-IN:8.1.2

M  +2    -3    src/alkonlinequote.cpp

https://invent.kde.org/office/alkimia/-/commit/cb65f11bc00a648bcdec57626d2a27b16c027fa8
Comment 2 Thomas Baumgart 2023-09-04 11:45:32 UTC
Git commit 228263661d07f91a72c2714e24881172ea37b5e6 by Thomas Baumgart.
Committed on 04/09/2023 at 13:05.
Pushed by tbaumgart into branch 'master'.

Fix error when retrieving data when no date was found

This commit fixes a bug that caused a general error when
retrieving an online source if no date was found when
parsing the quote.

(cherry picked from commit cb65f11bc00a648bcdec57626d2a27b16c027fa8)

M  +2    -3    src/alkonlinequote.cpp

https://invent.kde.org/office/alkimia/-/commit/228263661d07f91a72c2714e24881172ea37b5e6