Bug 473969 - Dark Icons on Dark Themes, resulting in poor contrast
Summary: Dark Icons on Dark Themes, resulting in poor contrast
Status: RESOLVED FIXED
Alias: None
Product: Tokodon
Classification: Applications
Component: general (show other bugs)
Version: 23.08.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Joshua Goins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-31 00:43 UTC by Izzy Jackson
Modified: 2023-12-10 12:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 23.12


Attachments
See the screenshot, dark icons are used, which makes them illegible agains the light theme. (404.06 KB, image/png)
2023-08-31 00:43 UTC, Izzy Jackson
Details
Regular Breeze Icons on Dark Colours (1.21 MB, image/png)
2023-09-13 14:08 UTC, Izzy Jackson
Details
Regular Breeze Icons on Breeze Dark Colour Scheme in Tokodon (1.12 MB, image/png)
2023-09-13 14:11 UTC, Izzy Jackson
Details
Breeze Dark Icons with Default Colours (1.13 MB, image/png)
2023-09-13 14:13 UTC, Izzy Jackson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Izzy Jackson 2023-08-31 00:43:38 UTC
Created attachment 161294 [details]
See the screenshot, dark icons are used, which makes them illegible agains the light theme.

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Use dark colour scheme in Tokodon, such as Breeze Dark or Breeze Dracula

OBSERVED RESULT
Icons use their dark versions, which makes them illegible against the dark background

EXPECTED RESULT
Icons use their light versions when using a dark theme, which is legible against the dark background.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 23.04 (using Backports PPA)
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 Joshua Goins 2023-09-11 19:18:11 UTC
Someone else seems to have run into this issue on Flatpak as well, really weird
Comment 2 Izzy Jackson 2023-09-13 14:07:20 UTC
Update: It's not just Flatpak on Kubuntu that's being problematic, running it as a native .RPM package on Fedora 38 also seems to be weird. If I launch it with the regular Breeze icon (attached screenshot), it works fine - icons are light against a dark background, and if I change the app's colour scheme to Breeze Light, it's dark on light. But if I load it with the Breeze Dark icon theme, it has the issue of poor contrast against the dark background. Elisa and Welcome Centre don't have this issue, so I'm confident in saying this is a Tokodon issue.
Comment 3 Izzy Jackson 2023-09-13 14:08:03 UTC
Created attachment 161604 [details]
Regular Breeze Icons on Dark Colours
Comment 4 Izzy Jackson 2023-09-13 14:11:08 UTC
Created attachment 161605 [details]
Regular Breeze Icons on Breeze Dark Colour Scheme in Tokodon

Interestingly, as I was testing this out, I found that if I set the in-app colour scheme to Breeze Dark as opposed to default, it works fine and the only difference is that it doesn't follow the UI theme.
Comment 5 Izzy Jackson 2023-09-13 14:13:56 UTC
Created attachment 161606 [details]
Breeze Dark Icons with Default Colours

If I use default colours, it has issues. The system theme is still Breeze Dark, just with an Accent Colour applied. 
Apologies for comments spam, I can only set one image at a time by the looks of things. Hopefully this makes it easier to solve.
Comment 6 Joshua Goins 2023-09-13 15:16:08 UTC
Thanks for the really detailed testing! This gives me much more to work with.
Comment 7 Joshua Goins 2023-10-19 19:57:48 UTC
I cannot reproduce on 23.08.2 anymore, at least with the Flatpak (Breeze or Breeze Dark icons). However, I suggest sticking to "Breeze" and not "Breeze Dark" as icons should color automatically.

In the next major release, all of the icon bugginess _should_ go away and icons should show the same behavior as other KDE applications. Unfortunately that's all I can really do as my bandwidth is limited :( If more people experience this issue, I might backport our fix early and see how that works.
Comment 8 Darius Drake 2023-12-10 12:05:49 UTC
(In reply to Joshua Goins from comment #7)
> I cannot reproduce on 23.08.2 anymore, at least with the Flatpak (Breeze or
> Breeze Dark icons). However, I suggest sticking to "Breeze" and not "Breeze
> Dark" as icons should color automatically.
> 
> In the next major release, all of the icon bugginess _should_ go away and
> icons should show the same behavior as other KDE applications. Unfortunately
> that's all I can really do as my bandwidth is limited :( If more people
> experience this issue, I might backport our fix early and see how that works.

I'm still having this issue in the latest Flatpak release. Either with Breeze or Breeze Dark icons.