Bug 473694 - Filled bookmarks icon
Summary: Filled bookmarks icon
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-23 18:44 UTC by Sune Vuorela
Modified: 2023-08-23 21:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.110
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sune Vuorela 2023-08-23 18:44:47 UTC
Hi

Based upon https://invent.kde.org/graphics/okular/-/merge_requests/810 (especially see video), a highlighted bookmarks icon would be nice, it could just be the current bookmarks.svg that was filled with the palette-correct red. 

If it gets named bookmarks-highlighted.svg (or bookmarks-somethingelse), then the application can just ask for bookmarks-highlighted, and it will get bookmarks-highlighted if available, and bookmarks if not. While not perfect, that's still pretty good.
Comment 1 Nate Graham 2023-08-23 20:06:37 UTC
We have empty and filled versions of the star icon ("starred" and "non-starred"); makes sense to do this for the bookmark icons too.
Comment 2 Bug Janitor Service 2023-08-23 20:28:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/283
Comment 3 Nate Graham 2023-08-23 21:06:15 UTC
Git commit 11ab65fb8dcdaeb24f228192bdef714ff880647f by Nate Graham.
Committed on 23/08/2023 at 22:28.
Pushed by ngraham into branch 'master'.

Add filled `bookmarks-bookmarked` icon

This facilitates the use case of alternating between the filled and
hollow styles--same as for the `rating` and `rating-unrated` icons.
FIXED-IN: 5.110

A  +1    -0    icons/actions/16/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/16/bookmarks-bookmarked.svg
A  +1    -0    icons/actions/22/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/22/bookmarks-bookmarked.svg
A  +1    -0    icons/actions/32/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/32/bookmarks-bookmarked.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/11ab65fb8dcdaeb24f228192bdef714ff880647f
Comment 4 Nate Graham 2023-08-23 21:07:29 UTC
Git commit a036c474f047b0f2f31d1755efe129a44e7566d0 by Nate Graham.
Committed on 23/08/2023 at 23:07.
Pushed by ngraham into branch 'kf5'.

Add filled `bookmarks-bookmarked` icon

This facilitates the use case of alternating between the filled and
hollow styles--same as for the `rating` and `rating-unrated` icons.
FIXED-IN: 5.110


(cherry picked from commit 11ab65fb8dcdaeb24f228192bdef714ff880647f)

A  +1    -0    icons/actions/16/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/16/bookmarks-bookmarked.svg
A  +1    -0    icons/actions/22/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/22/bookmarks-bookmarked.svg
A  +1    -0    icons/actions/32/bookmarks-bookmarked-symbolic.svg
A  +10   -0    icons/actions/32/bookmarks-bookmarked.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/a036c474f047b0f2f31d1755efe129a44e7566d0