Bug 473363 - Avatar page is not scrollable until resizing the window in Qt6.8
Summary: Avatar page is not scrollable until resizing the window in Qt6.8
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (show other bugs)
Version: master
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-08-14 13:06 UTC by Fushan Wen
Modified: 2024-01-16 21:13 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2023-08-14 13:06:44 UTC
SUMMARY
The Avatar OverlaySheet doesn't have a scrollbar even if the content can't be accommodated in the current area. Resizing the system settings window can work around it.


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version:  plasma-workspace at b910507a4cd36a211b4d14ccd133c39f196033b1
KDE Frameworks Version: 
Qt Version: 6.5.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-08-14 20:56:03 UTC
Can reproduce.
Comment 2 Nate Graham 2023-08-14 20:58:49 UTC
StackView docs say: "StackView does not inherit an implicit size from items that are pushed onto it."

I have a feeling this is what we're running into.
Comment 3 Nate Graham 2023-08-30 21:35:26 UTC
For me it becomes scrollable if I resize the window to be larger and then smaller again.
Comment 4 Bug Janitor Service 2023-09-30 15:49:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/302
Comment 5 Bug Janitor Service 2023-12-04 11:43:14 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3649
Comment 6 Harald Sitter 2023-12-04 11:44:28 UTC
I can't help but wonder if we should port away from the sheet tech and use a regular page on the stack instead. This isn't the first silly bug we've had with it. I suspect it also won't be the last.
Comment 7 Nate Graham 2023-12-04 15:09:56 UTC
In this case I agree. The sheet takes up 95% of the available space anyway, which suggests that it wanted to be a page all along.
Comment 8 Harald Sitter 2023-12-04 15:29:16 UTC
Git commit 2869a550ec4e33108f0aa0e9ee7683b785c0a45d by Harald Sitter.
Committed on 04/12/2023 at 12:41.
Pushed by ngraham into branch 'master'.

kcms/users: derive columns count from implicitWidth

otherwise **I think** we have an implicit dependency loop where the
effective width of the StackView depends on its content, but its content
width depends on the width of the view. meanwhile implicitWidth is
simply the page width minus spacing so that is always a fixed value we
can hold onto for the maximum width we may be able to occupy

M  +1    -2    kcms/users/src/ui/PicturesSheet.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/2869a550ec4e33108f0aa0e9ee7683b785c0a45d
Comment 9 Fushan Wen 2024-01-13 00:26:55 UTC
Regression in Qt6.8
Comment 10 fanzhuyifan 2024-01-13 00:29:11 UTC
(In reply to Fushan Wen from comment #9)
> Regression in Qt6.8

Do you mean Q6.7?
Comment 11 Nate Graham 2024-01-16 21:13:01 UTC
Let's get a new bug report going for that, since it'll end up being a separate issue from this one, and we also aren't formally supporting either Qt 6.7 or 6.8 yet. Thanks!