Created attachment 160867 [details] GlobalDrawer Loader patch for Kirigami gallery SUMMARY Both Elisa and Koko use Loaders to store the global drawer sidebar to only activate it under certain conditions (e.g. mobile-only) STEPS TO REPRODUCE 1. Apply the provided patch to kirigami-gallery and compile 2. Click the hamburger menu in the top left OBSERVED RESULT The drawer handle changes as if the drawer is opened, but its location does not. The sidebar itself is not visible. EXPECTED RESULT Sidebar opens as usual SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20230806 KDE Plasma Version: 5.27.7 KDE Frameworks Version: 5.108.0 Qt Version: 5.15.10 Kernel Version: 6.4.8-1-default (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION
Is the problem visible in Elisa? it seems to be working fine for me in its KF6 version.
Created attachment 160887 [details] Elisa empty global drawer This is what I see in Elisa. Note that Elisa forces a specific width, which is why the drawer handle is not at the side of the screen.
Is that the mobile UI? I'm not seeing the issue there. Of course the mobile UI is a bit broken in Qt 6 right now, unfortunately.
Yes it's with QQC2_CONTROLS_MOBILE=1 set. Also I replaced "iconName" -> "icon.name" to allow it to run on Qt6, and removed the line "visible = false;" to see the drawer handle (otherwise the drawer would be completely transparent and didn't appear to open)
Can we get those changed submitted to Elisa first?
(In reply to Nate Graham from comment #5) > Can we get those changed submitted to Elisa first? I was planning on doing so but there's no way for me to test if the sidebar doesn't show me anything.
I meant the other changes unrelated to the sidebar. FWIW with Elisa'a current git mater, I can see the sidebar in the mobile UI, but it's the handle to close it that's missing.
Can confirm the issue with https://invent.kde.org/multimedia/elisa/-/merge_requests/477 applied to Elisa.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1326
Big respect for the patch to Kirigami Gallery that helps reproducing the problem.
Git commit 1a969a18d91a006420594cf86d8c65bb51a1ec3f by ivan tkachenko, on behalf of Jack Hill. Committed on 11/10/2023 at 18:07. Pushed by ratijas into branch 'appwindow-global-drawer-bindings'. AbstractApplicationWindow: Clean up bindings, fix reparenting of drawers Querying QQC2.Overlay.overlay attached property on a Binding object was clearly wrong. It just resulted in null at all times, so basically those Bindings never took effect. Since `when:` condition does not make much sense (first, those properties could never be undefined; second, why reparenting only when visible?), let's demote them into a property change handlers with null guards. For other bindings, pointless `when` check was removed as well as deprecated (and yet again pointless) restoreMode. Co-Authored-By: Jack Hill <jackhill3103@gmail.com> M +20 -22 src/controls/AbstractApplicationWindow.qml https://invent.kde.org/frameworks/kirigami/-/commit/1a969a18d91a006420594cf86d8c65bb51a1ec3f
Git commit 74e6a852d2f55ad9c53f34972fe3ba0c1ad78c42 by ivan tkachenko. Committed on 18/10/2023 at 12:13. Pushed by ratijas into branch 'master'. AbstractApplication*: Fix reparenting of drawers, Clean up bindings Querying T.Overlay.overlay attached property on a Binding object was clearly wrong. It just resulted in null at all times, so basically those Bindings never took effect. Since `when:` condition does not make much sense (first, those properties could never be undefined; second, why reparenting only when visible?), let's demote them into a property change handlers with null guards. For other bindings, pointless `when` check was removed as well as deprecated (and yet again pointless) restoreMode. Co-Authored-By: Jack Hill <jackhill3103@gmail.com> M +61 -1 autotests/tst_globaldrawer.qml M +21 -37 src/controls/AbstractApplicationItem.qml M +24 -26 src/controls/AbstractApplicationWindow.qml https://invent.kde.org/frameworks/kirigami/-/commit/74e6a852d2f55ad9c53f34972fe3ba0c1ad78c42