Bug 473128 - Fetching currency conversions from fx-rate.net is broken
Summary: Fetching currency conversions from fx-rate.net is broken
Status: RESOLVED DOWNSTREAM
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.1.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
: 473309 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-08-08 01:18 UTC by itorsics
Modified: 2023-08-12 09:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description itorsics 2023-08-08 01:18:22 UTC 
SUMMARY
Cannot fetch currency conversions


STEPS TO REPRODUCE
1. Run "Update stock and currency prices" from the menu

OBSERVED RESULT
Produces the following output:

Fetching URL https://fx-rate.net/CAD/USD...
Identifier found: 'CAD/USD'
Date found: 'Mon. Aug. 7 2023'
Unable to update price for CAD > USD (no price or no date)

SOFTWARE/OS VERSIONS
Linux (Ubuntu 23.04)
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
I tried looking at the regex contained at line 584 in "webpricequote.cpp". The problem seems to be that the output from fx-rate.net doesn't put a space inside the br tag. I think that adding a "*" after the "\s" in the br tag in the regex should fix the issue, but I haven't recompiled the source to make sure.
Comment 1 Thomas Baumgart 2023-08-08 06:36:06 UTC 
Thank you for the analysis. Recompiling won't help you, because those values are only used when the application is run for the first time. After that, use "Settings/Configure KMyMoney/Online Quotes" to modify the regex. An updated regex could be found e.g. on https://discuss.kde.org/t/kmoney-currency-udpates-not-working/3037
Comment 2 david.houlden 2023-08-12 09:29:33 UTC 
*** Bug 473309 has been marked as a duplicate of this bug. ***