Bug 473011 - Items in some KCMs don't get highlighted when hovering with the mouse
Summary: Items in some KCMs don't get highlighted when hovering with the mouse
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-08-04 19:35 UTC by guimarcalsilva
Modified: 2023-08-31 17:23 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2023-08-04 19:35:22 UTC
SUMMARY
Items in Application Style, Window Decoration, and Cursors only get highlighted if you hover over the border, not with the cursor on top of the previews.

Compared to Plasma 5, highlights in other KCMs are also different. On the Desktop Effects page, only the description gets bold on mouse hover. On pages without descriptions for list items like Virtual Desktops, Activities, and Window Rules there's no visible highlight anymore compared to Plasma 5.

Pages like Kwin Scripts, File Search, Plasma Search, and Region & Language didn't have highlights in Plasma 5 and continue to not have them in Plasma 6, which can look inconsistent though it's not a regression.

OBSERVED RESULT
Some items seem to get highlighted, others do not.

EXPECTED RESULT
Consistent highlights throughout System Settings.

SOFTWARE/OS VERSIONS
KDE Plasma: 5.27.90
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Kernel Version: 6.2.0-26-generic
Graphics Platform: X11

ADDITIONAL INFORMATION
Tested on a VM
Comment 1 Nate Graham 2023-08-07 20:52:42 UTC
Can reproduce.
Comment 2 Ismael Asensio 2023-08-18 18:54:08 UTC
Git commit 9add143a40f10a85fb5d9c319013381c1458ba02 by Ismael Asensio.
Committed on 18/08/2023 at 20:39.
Pushed by iasensio into branch 'master'.

kcms/decoration: Fix highlight when hovering the preview

The preview item implements hover event filters, which by default
are accepted and not propagated to their parent, breaking the
hightlight on hover for the GridView.

We can simply "ignore()" those events so they are propagated,
but still fully functional.

Preemptively, do the same also for mouse events, which seem to be
already propagated now, but shouldn't according to the QQuickItem
documentation.

M  +2    -0    src/kcms/decoration/declarative-plugin/previewitem.cpp

https://invent.kde.org/plasma/kwin/-/commit/9add143a40f10a85fb5d9c319013381c1458ba02
Comment 3 Bug Janitor Service 2023-08-18 19:09:57 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3196
Comment 4 Ismael Asensio 2023-08-18 19:40:41 UTC
Git commit 242a9b7e79c04beeb99a0127c83a32bac1e4555e by Ismael Asensio.
Committed on 18/08/2023 at 20:46.
Pushed by iasensio into branch 'master'.

kcms/style: Fix highlight when hovering the preview

The PreviewItem implements hover event filters, which by default
are accepted and not propagated to their parent, breaking the
hightlight on hover for the GridView.

We can simply "ignore()" those events so they are propagated,
but still fully functional.

M  +4    -1    kcms/style/previewitem.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/242a9b7e79c04beeb99a0127c83a32bac1e4555e
Comment 5 Ismael Asensio 2023-08-21 15:25:18 UTC
Git commit f389824cd9980bb1cd07241d92fcb6676d5fff8d by Ismael Asensio.
Committed on 21/08/2023 at 17:12.
Pushed by iasensio into branch 'master'.

kcms/cursortheme: Fix highlight when hovering the preview

The PreviewItem implements hover event filters, which by default
are accepted and not propagated to their parent, breaking the
hightlight on hover for the GridView.

We can simply "ignore()" those events so they are propagated,
but still fully functional.

M  +4    -1    kcms/cursortheme/xcursor/previewwidget.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/f389824cd9980bb1cd07241d92fcb6676d5fff8d
Comment 6 Nate Graham 2023-08-30 22:30:37 UTC
This appears to be fixed in all grid view KCMs now.
Comment 7 guimarcalsilva 2023-08-30 22:38:47 UTC
(In reply to Nate Graham from comment #6)
> This appears to be fixed in all grid view KCMs now.

Is it fixed for elements that aren't on a grid? Like these ones in the original description:

>On the Desktop Effects page, only the description gets bold on mouse hover. On pages without descriptions for list items like Virtual Desktops, Activities, and Window Rules there's no visible highlight anymore compared to Plasma 5.

The last time I tried with Neon Unstable the issue in those pages was still present.
Comment 8 Nate Graham 2023-08-31 17:23:18 UTC
Sorry, I missed that part. I can reproduce that issue in the Desktop Effects KCM, which likely has a different root cause. Let's track that separately in Bug 473997.

The lack of hover highlights in other KCMs is intentional at this point, since there's nothing you can do with them when they're selected.