Bug 472700 - Fill tool in color label reference mode is affected by layers contained in hidden group layers
Summary: Fill tool in color label reference mode is affected by layers contained in hi...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Deif Lou
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 14:20 UTC by 010freeze010
Modified: 2024-02-28 18:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description 010freeze010 2023-07-27 14:20:22 UTC
STEPS TO REPRODUCE
1. Create a document with the following structure.
Layer1. Empty paint layer(Show, No color label)
Layer2. Group layer(Hide, No color label)
Layer3. Inside Layer 2,Paint layer with a something painted on it(Show, blue color label)
2. Activate the Fill tool, put it in color label reference mode, and select the blue label.
3. Try a fill on layer 1.

OBSERVED RESULT
The fill is affected by a paint layer (Layer 3) inside a group layer (Layer 2) that is hidden.

EXPECTED RESULT
Since the group layer (Layer 2) is hidden, the fill tool should function unaffected by the paint layer (Layer 3) inside it.
Comment 1 Bug Janitor Service 2023-07-28 10:34:05 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1872
Comment 2 Deif Lou 2023-08-01 05:13:48 UTC
Git commit 943278915682af369ef76cdc24c83f4f98da4530 by Deif Lou.
Committed on 01/08/2023 at 06:55.
Pushed by deiflou into branch 'master'.

Fix issues generating reference image in KisMergeLabeledLayersCommand
Related: bug 471896

M  +113  -35   libs/image/commands_new/KisMergeLabeledLayersCommand.cpp
M  +4    -5    libs/image/commands_new/KisMergeLabeledLayersCommand.h

https://invent.kde.org/graphics/krita/-/commit/943278915682af369ef76cdc24c83f4f98da4530
Comment 3 Dmitry Kazakov 2024-02-28 18:09:27 UTC
Git commit 44f0d93ef6fa3c8e46d23af53346c4854b63ac45 by Dmitry Kazakov, on behalf of Deif Lou.
Committed on 28/02/2024 at 12:34.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix issues generating reference image in KisMergeLabeledLayersCommand
Related: bug 471896

M  +113  -35   libs/image/commands_new/KisMergeLabeledLayersCommand.cpp
M  +4    -5    libs/image/commands_new/KisMergeLabeledLayersCommand.h

https://invent.kde.org/graphics/krita/-/commit/44f0d93ef6fa3c8e46d23af53346c4854b63ac45