Bug 472679 - Modifier-only shortcut handling is broken in KeySequenceItem, which is used in applet configure dialogs
Summary: Modifier-only shortcut handling is broken in KeySequenceItem, which is used i...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.27.10
Platform: Other Linux
: HI major
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 479827 (view as bug list)
Depends on:
Blocks: 371560
  Show dependency treegraph
 
Reported: 2023-07-26 19:04 UTC by Nate Graham
Modified: 2024-01-26 16:31 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments
ALT+... => waiting for another key (18.95 KB, image/jpeg)
2024-01-18 15:41 UTC, Alexis-Emmanuel Haeringer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-07-26 19:04:17 UTC
STEPS TO REPRODUCE
1. Open System Tray > click on "Configure" button
2. Go to "Keyboard Shortcuts" page
3. Click the "None" button
4. Hit a modifier key on your keyboard, and no other keys


OBSERVED RESULT
The shortcut chooser waits for you to enter a non-modifier key.


EXPECTED RESULT
The modifier key is used as the shortcut, all on its own.


ADDITIONAL INFORMATION
This used to work, but appears to have broken at some point. Can reproduce in Plasma 5.27.6 as well as Plasma 6.
Comment 1 Alexis-Emmanuel Haeringer 2024-01-18 15:41:42 UTC
Created attachment 165009 [details]
ALT+... => waiting for another key
Comment 2 Nate Graham 2024-01-18 21:40:17 UTC
*** Bug 479827 has been marked as a duplicate of this bug. ***
Comment 3 Bug Janitor Service 2024-01-25 10:41:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2009
Comment 4 Nate Graham 2024-01-26 16:29:12 UTC
Git commit f358d5fdfd9eae4c7f02b9d5147e6f62b42f3752 by Nate Graham, on behalf of David Redondo.
Committed on 26/01/2024 at 17:26.
Pushed by ngraham into branch 'master'.

Allow modifier only shortcuts in applet configuration dialog

These are global shortcuts and modifier only shortcuts can already
assigned through systemsettings.
FIXED-IN:6.0

M  +1    -0    desktoppackage/contents/configuration/ConfigurationShortcuts.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/f358d5fdfd9eae4c7f02b9d5147e6f62b42f3752
Comment 5 Nate Graham 2024-01-26 16:31:00 UTC
Git commit b8545bbce94ce0bd487e0e6e5183f5c777170811 by Nate Graham, on behalf of David Redondo.
Committed on 26/01/2024 at 17:30.
Pushed by ngraham into branch 'Plasma/6.0'.

Allow modifier only shortcuts in applet configuration dialog

These are global shortcuts and modifier only shortcuts can already
assigned through systemsettings.
FIXED-IN:6.0


(cherry picked from commit f358d5fdfd9eae4c7f02b9d5147e6f62b42f3752)

M  +1    -0    desktoppackage/contents/configuration/ConfigurationShortcuts.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/b8545bbce94ce0bd487e0e6e5183f5c777170811