STEPS TO REPRODUCE 1. Plug in a USB storage device 2. In Disks & Devices popup, click "Mount and open" OBSERVED RESULT Nothing happens EXPECTED RESULT The disk is mounted and opened in Dolphin ADDITIONAL INFORMATION Journal log says: Jul 25 12:26:36 Liberator plasmashell[451395]: kf.service.services: The desktop entry file "/home/nate/kde/usr6/share/solid/actions/test-predicate-openinwindow.desktop" has Type= "Service" instead of "Application" Jul 25 12:26:36 Liberator plasmashell[451395]: Failed to resolve hotplugjob action "test-predicate-openinwindow.desktop" "/home/nate/kde/usr6/share/solid/actions/test-predicate-openinwindow.desktop"
KService rejects files of Type=Service now. I wouldn't want to have to change all the Solid device actions (which could come from 3rd parties or be user-generated) to be Type=Application (which I also think isn't really correct). So I guess the best bet is to port it to use KDesktopFile instead of KService to parse those.
Makes sense. I do see errors for other ones too: Aug 04 11:30:03 Liberator plasmashell[7474]: kf.service.services: The desktop entry file "/home/nate/kde/usr6/share/solid/actions/gwenview_importer.desktop" has Type= "Service" instead of "Application" Aug 04 11:30:03 Liberator plasmashell[7474]: kf.service.services: The desktop entry file "/home/nate/kde/usr6/share/solid/actions/open_in_partitionmanager.desktop" has Type= "Service" instead of "Application"
Git commit e1729db2df7f74fb7c28d27dc3942a79558e2c33 by Nate Graham. Committed on 01/09/2023 at 21:02. Pushed by ngraham into branch 'master'. applets/devicenotifier: open filemanager with kde-open, not kde-open5 M +1 -1 applets/devicenotifier/test-predicate-openinwindow.desktop https://invent.kde.org/plasma/plasma-workspace/-/commit/e1729db2df7f74fb7c28d27dc3942a79558e2c33
Git commit aed214de28779fb70a19a6c9410c931f4e3b6c93 by Nate Graham. Committed on 01/09/2023 at 21:13. Pushed by ngraham into branch 'master'. applets/devicenotifier: Rename test-predicate-openinwindow.desktop We own this file and also own the code where it's called by name--in the same repo, to boot! Therefore there's no reason why we can't give it a more comprehensible name. So let's do it. M +1 -1 applets/devicenotifier/CMakeLists.txt R +0 -0 applets/devicenotifier/openWithFileManager.desktop [from: applets/devicenotifier/test-predicate-openinwindow.desktop - 100% similarity] M +2 -2 applets/devicenotifier/package/contents/ui/DeviceItem.qml M +3 -1 dataengines/hotplug/deviceserviceaction.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/aed214de28779fb70a19a6c9410c931f4e3b6c93
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3241
Looks like this is already fixed by https://invent.kde.org/frameworks/kservice/-/commit/b32418a5601e9ffcb7594174d2f59d19bf43950f, which reverted the change that necessitated the merge request that I submitted.