Bug 472512 - Remove Stack and Global Blocks from debuginfo handling.
Summary: Remove Stack and Global Blocks from debuginfo handling.
Status: ASSIGNED
Alias: None
Product: valgrind
Classification: Developer tools
Component: sgcheck (other bugs)
Version First Reported In: 3.21.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Mark Wielaard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-22 21:32 UTC by Mark Wielaard
Modified: 2023-07-22 21:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Remove Stack and Global Blocks from debuginfo handling. (17.51 KB, text/plain)
2023-07-22 21:32 UTC, Mark Wielaard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wielaard 2023-07-22 21:32:15 UTC
Created attachment 160455 [details]
Remove Stack and Global Blocks from debuginfo handling.

The VG_(di_get_stack_blocks_at_ip) and
VG_(di_get_global_blocks_from_dihandle) functions
were only used by the exp-sgcheck tool.
    
Since this tool was removed a couple of years back this code hasn't
been used or tested. Lets remove it to reduce the complexity of
dealing with debuginfo.
Comment 1 Mark Wielaard 2023-07-22 21:35:57 UTC
I wrote this while trying to understand https://bugs.kde.org/show_bug.cgi?id=471807
This code confused me till I realized it isn't actually used (and was last changed in 2008).
So I think it is best to just remove it so it doesn't confuse others.