Bug 472458 - Confirmation for "Closing Windows with multiple Tabs" doesn't work
Summary: Confirmation for "Closing Windows with multiple Tabs" doesn't work
Status: RESOLVED WORKSFORME
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 22.12.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-21 07:35 UTC by zb4ng
Modified: 2025-01-16 10:05 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description zb4ng 2023-07-21 07:35:18 UTC
SUMMARY
If I click accidentally on a "close" symbol of a dolphin window with multiple folders, it is closed without confirmation, even if I have configured the confirmation. 
This happens in openSUSE LEAP as well as Ubuntu LTS.
Can you please fix this, that I don't have to search for all those folders?

STEPS TO REPRODUCE
1. Go to Settings->Configure Dolphin->Confirmations
2. Check the box next to Confirmation for "Closing Windows with multiple Tabs"
3. Open multiple tabs in one dolphin window
4. Click on "x"-symbol in the title bar (presumably the rightmost symbol)

OBSERVED RESULT
The window is closed at once.

EXPECTED RESULT
A confirmation message box appears: "Really close this window with multiple tabs? Yes/Cancel"

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
- openSUSE LEAP: 15.5
- Ubuntu LTS 22.04
KDE Plasma Version: 
5.27.4 + 5.24.7
KDE Frameworks Version: 
5.103.0+5.92.0
Qt Version: 
5.15.8+5.15.3

Thanks.
Comment 1 Ben Bonacci 2023-07-24 10:57:23 UTC
On Dolphin version 23.04.3 the confirmation prompt appears as expected.
Have you tried updating to this version (if its available for your LTS distributions) and see if the problem continues?

If not, you could consider using the Flatpak version until its available in the repositories.
Comment 2 zb4ng 2023-07-24 16:16:02 UTC
(In reply to Ben Bonacci from comment #1)
> On Dolphin version 23.04.3 the confirmation prompt appears as expected.
> Have you tried updating to this version (if its available for your LTS
> distributions) and see if the problem continues?
> 
> If not, you could consider using the Flatpak version until its available in
> the repositories.

I have an issue with Flatpak atm, so I couldn't test this...
It's fine, if it works in the newer version of Dolphin. I hope Suse upgrades to the next minor version soon.

I have found an old Suse Tumbleweed partition, so maybe, I'll check it there later, if I get it running...
Comment 3 zb4ng 2023-07-31 06:21:39 UTC
(In reply to zb4ng from comment #2)
> (In reply to Ben Bonacci from comment #1)
> > On Dolphin version 23.04.3 the confirmation prompt appears as expected.
>  ....
> I have found an old Suse Tumbleweed partition, so maybe, I'll check it there
> later, if I get it running...

I checked it in Tumbleweed and the bug occurs there also even with Dolphin 23.04.3...
Comment 4 Bug Janitor Service 2023-08-15 03:45:16 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 zb4ng 2023-08-15 12:08:28 UTC
(In reply to Ben Bonacci from comment #1)
> On Dolphin version 23.04.3 the confirmation prompt appears as expected.
> Have you tried updating to this version (if its available for your LTS
> distributions) and see if the problem continues?
> 
> If not, you could consider using the Flatpak version until its available in
> the repositories.

I tested it now with Flatpak (Dolphin version 23.04.3): didn't change any settings, just tried to reproduce the bug..., it is still there! 
It appears on my Chromebook also (with Linux Development Environment, but older Dolphin version) .
This is really weird...
Comment 6 Amol Godbole 2023-08-19 17:23:13 UTC
The confirmation message will not be displayed if the dolphin setting for 'remember opened tabs' has been selected. 
This is available in Settings->Configure Dolphin->Startup->Show on startup->Folders, tabs, and window state from last time. 

Could you please confirm if you have not configured dolphin to remember tabs?
Comment 7 zb4ng 2023-08-20 08:18:06 UTC
(In reply to Amol Godbole from comment #6)
> The confirmation message will not be displayed if the dolphin setting for
> 'remember opened tabs' has been selected. 
> This is available in Settings->Configure Dolphin->Startup->Show on
> startup->Folders, tabs, and window state from last time. 
> 
> Could you please confirm if you have not configured dolphin to remember tabs?

Yes, it is as you said:
If "Folders, tabs, and window state from last time. " is selected, then the confirmation message is not displayed.   
If the radio button is in the other state (next to the field with the folder), the confirmation box "You have multiple tabs open in this window, are you sure you want to quit?" appears.

I tried the second option (= go to some default folder on startup) and when I rebooted, all the folders from last time were there. So this seems to work for me now, but I find it a bit confusing:
- Why are those two settings linked ?
- Does the second option do anything ?
- If I press "Quit Dolphin" in the confirmation box, only the tabs of the current window will be closed (which is what I want!). However, the button text "Quit Dolphin") suggests that all Dolphin windows will be closed, hence I was at first hesitant to try it.

If this behavior is deliberate, this issue can be closed from my pov.
Thanks!
Comment 8 Méven Car 2023-08-22 07:29:41 UTC
https://bugs.kde.org/show_bug.cgi?id=472458#c7

> - Why are those two settings linked ?

Because they are in conflict with each other, one has to take precedence.

"Show on startup->Folders, tabs, and window state" takes precedence as it guarantees not to loose information (you can just reopen dolphin get its state again).

> - Does the second option do anything ?
> I tried the second option (= go to some default folder on startup) and when I rebooted

This is not dolphin that influenced this but most likely the Plasma session restore feature, that will restore your application state as they were the moment you rebooted regardless of those settings.