Bug 472451 - Bug: Perform "Toggle All Track Lock" just will not act in the selected track.
Summary: Bug: Perform "Toggle All Track Lock" just will not act in the selected track.
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (show other bugs)
Version: 23.04.2
Platform: Microsoft Windows Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-21 02:56 UTC by Mat.
Modified: 2023-07-24 16:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Showing the issue. (3.10 MB, video/mp4)
2023-07-21 02:56 UTC, Mat.
Details
Showing the same edit with Switch All Tracks Activate or Toggle All Tracks Lock (2.33 MB, video/mp4)
2023-07-22 12:21 UTC, Mat.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mat. 2023-07-21 02:56:07 UTC
Created attachment 160416 [details]
Showing the issue.

SUMMARY

Bug: Perform "Toggle All Track Lock" just will not act in the selected track.

STEPS TO REPRODUCE
1. It be in some tab with Timeline.
2. Perform the "Toggle All Track Lock" (Timeline > Tracks > Toggle All Track Lock or with default keyboard shortcut "Ctrl + Shift + L").

OBSERVED RESULT
All tracks will be locks, except the track that is selected. If perform again, all tracks will unlock, but the select track will lock.

EXPECTED RESULT
All tracks should to be lock or unlock.

SOFTWARE/OS VERSIONS
Windows: Windows 10 Version 2009 (x86_64)
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.9 (built against 5.15.9)

ADDITIONAL INFORMATION
"Selected track" meaning the background fill that appear in the tracks. Realise this "background fill" changing the select track with the default keyboard shortcut, for video track, "1", "2" or for audio track, "Alt + 1", "Alt + 2".
Comment 1 Jean-Baptiste Mardelle 2023-07-21 07:44:10 UTC
Thanks for your report, I can confirm the issue. In fact, looks like it was the wanted behavior to leave the active track unlocked.
The idea is that you might want to lock all tracks except the current one to ensure your next operations don't touch the other track.
However the behavior is not very consistent as repeating the action unlocks all other tracks but locks the active one.
Not sure what is the best behavior for this, but we should consistently toggle either all tracks or all tracks except the active one. Will ask for Massimo's input on this.
Comment 2 Mat. 2023-07-21 12:05:14 UTC
If you need my opinion, I would prefer that it lock or unlock all tracks.
But, anyway, I glad to help!
Comment 3 Jean-Baptiste Mardelle 2023-07-22 07:21:41 UTC
Yes, thanks for your feedback. The idea was that it's not so useful to lock all tracks at once. So to make the tool more useful, we used the current (inconsistent) behavior. So to make it consistent, we should either rename the command to "Toggle all tracks lock except current" and make it behave consistently (never touch the locked state of the current track), or make the action really toggle all tracks without considering the current track.

What seems the most useful to you?
Comment 4 Mat. 2023-07-22 12:18:21 UTC
Hi, Jean.

I don't know if I am the best user to make the answer to decide that, 😅.

Thought in depth, if you use "Toggle all tracks lock except current" to isolate the track and don't make the another tracks react the next clip to add, it's also possible doing the combination: "Switch all tracks activate", and "Toggle track activate" to desire track that will receive the clip.

I added new attachment to understand what I am saying, rs.

I suppose the "Toggle all tracks lock" is feature more common in Video Editing, so it would good if the KDEnlive have too.

Summary: I agree toggle every single tracks lock.
Comment 5 Mat. 2023-07-22 12:21:19 UTC
Created attachment 160444 [details]
Showing the same edit with Switch All Tracks Activate or Toggle All Tracks Lock
Comment 6 Jean-Baptiste Mardelle 2023-07-24 16:35:11 UTC
Git commit 2d87a5ad197bcf55bda1b4e8f794c042a20874cb by Jean-Baptiste Mardelle.
Committed on 24/07/2023 at 18:34.
Pushed by mardelle into branch 'release/23.08'.

Make Toggle all tracks lock consistent, toggling all tracks.

M  +2    -19   src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/2d87a5ad197bcf55bda1b4e8f794c042a20874cb