Bug 472101 - The buttons used to pick font and shadow colors of subtitles do not reflect the current colors
Summary: The buttons used to pick font and shadow colors of subtitles do not reflect t...
Status: RESOLVED FIXED
Alias: None
Product: Haruna
Classification: Applications
Component: generic (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: george fb
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-07-09 13:34 UTC by Patrick Silva
Modified: 2023-07-09 16:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-07-09 13:34:06 UTC
STEPS TO REPRODUCE
1. open haruna settings 
2. click on "Subtitles" in the left side
3. pick any color for shadow or font, except white

OBSERVED RESULT
the buttons used to pick the colors are still in white

EXPECTED RESULT
the buttons should reflect the current colors

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.1
Graphics Platform: Wayland
Comment 1 Patrick Silva 2023-07-09 13:49:35 UTC
The button used to pick the border color is updated after switching to another section of the settings and then going back to "Subtitles".
Comment 2 george fb 2023-07-09 16:46:11 UTC
Git commit 5334f8f6f9c5cdddd510179f4b783b486e939bf1 by George Florea Bănuș.
Committed on 09/07/2023 at 16:44.
Pushed by georgefb into branch 'master'.

SubtitlesSettings: fixed color picker buttons not reflecting the current color

M  +3    -1    src/qml/Haruna/Components/ColorPickerButton.qml
M  +25   -0    src/qml/Settings/SubtitlesSettings.qml

https://invent.kde.org/multimedia/haruna/-/commit/5334f8f6f9c5cdddd510179f4b783b486e939bf1