Bug 471921 - auto-fill the "detect window" values when opening through window dialog
Summary: auto-fill the "detect window" values when opening through window dialog
Status: RESOLVED INTENTIONAL
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinrules (show other bugs)
Version: 5.27.4
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-03 22:53 UTC by Henning
Modified: 2023-09-15 06:13 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henning 2023-07-03 22:53:00 UTC
When clicking on it, get the values of the screen like after the "get window properties" feature when clicking on the screen

The already set information is often not enough, most often that you want to differenciate between dialogs and main window. So having this is really helpful.

The dialog is well understandable, but its weird that after already clicking "edit window behavior for THIS WINDOW" you again need to detect features of that window, even though you used its menu to open the dialog in the first hand.
Comment 1 Nate Graham 2023-09-13 18:36:18 UTC
> When clicking on it, get the values of the screen
That might not be what you want though. We can't assume that this is what the user had in mind.

Window Rules are an advanced feature and users are expected to be able to specify exactly what it is that they want.
Comment 2 Henning 2023-09-14 23:03:04 UTC
I agree with setting the window rules to hidden (closed other issues)

But at least this should be easier. You open the dialog from a window, but it doesnt get the matching values. I dont think this is intentional, as it doesnt make much sense. 

You could still de-select some values, as this would be no problem. It would even more be overspecific and not generally break things. So easier and faster, saving space and I think it would make sense
Comment 3 Ismael Asensio 2023-09-15 06:13:52 UTC
(In reply to Henning from comment #2)
> I agree with setting the window rules to hidden (closed other issues)
> 
> But at least this should be easier. You open the dialog from a window, but
> it doesnt get the matching values. I dont think this is intentional, as it
> doesnt make much sense. 
> 
> You could still de-select some values, as this would be no problem. It would
> even more be overspecific and not generally break things. So easier and
> faster, saving space and I think it would make sense

I don't understand this. When opening Window Rules from a window menu, it already get the window values (in fact it goes through the same code path as when detecting). It doesn't fill all of the values because usually those are not needed, but they're accesible under the "Add properties" list. No need to detect again on the same window