SUMMARY After compiling from sources, terminal presents some issues STEPS TO REPRODUCE 1. Open kile 2. Click for terminal, have window is blank and at standard size, last line maybe invisible 3. Folder for terminal is not the one of the active file OBSERVED RESULT See above EXPECTED RESULT Normal behavior of konsole inside kile SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora 38 (available in About System) KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.107.0 Qt Version: 5.15.10 ADDITIONAL INFORMATION
Same issues after today changes. Eliminating the changes in konsolewidgets.cpp solves the problem
I see no change after last commits, I wonder if it can be caused by my configuration. I added Nicolas Fella as cc
I checked with the last commits of Christopher Grüninger (added as cc) that the problems persist. I wonder if somewhere horizontal and vertical lengths have been exchanged. It is also possible that it is a consequence of other settings but I created a new user and the same happens.
I can confirm the regression. Konsole has the wrong size. Thanks for reporting! I think the regression was introduced with 79ef2b5b (Port away from deprecated KPluginLoader) The last commit where it is working for me is fd3ff5ac, the parent the commit above. @enriquie, can you confirm it is the commit?
Yes, actually, i have a branch in my computer without the changes related to konsole, and it works; I tried to figure out where the problem was but I failed. Thanks four your nice work.
Git commit cb5ec2ee84d8b9438dd88e21e235eed2287e5020 by Michel Ludwig. Committed on 12/11/2023 at 12:02. Pushed by mludwig into branch 'master'. Load and instantiate 'konsolepart' via KPluginFactory (analogously to how Kate is doing it) M +11 -7 src/widgets/konsolewidget.cpp https://invent.kde.org/office/kile/-/commit/cb5ec2ee84d8b9438dd88e21e235eed2287e5020
Thanks!