Bug 471323 - plasma welcome pops up on upgrade in live mode
Summary: plasma welcome pops up on upgrade in live mode
Status: RESOLVED FIXED
Alias: None
Product: Welcome Center
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-06-22 09:51 UTC by Jonathan Riddell
Modified: 2023-06-22 14:21 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (39.19 KB, image/png)
2023-06-22 09:51 UTC, Jonathan Riddell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Riddell 2023-06-22 09:51:55 UTC
Created attachment 159829 [details]
screenshot

I upgraded my packages in KDE neon unstable edition today and up popped the welcome centre during the upgrade.  It is in live installed.

This is the config file while the plasma-welcome is running

~/.config>cat plasma-welcomerc 
[General]
LastSeenVersion=5.27.80

There is no logo shown.
Comment 1 Oliver Beard 2023-06-22 10:17:57 UTC
This happens because KDED is restarted during installation, which causes the autostart service to start and launch Welcome Center again.

https://invent.kde.org/plasma/plasma-welcome/-/blob/master/src/kded/daemon.cpp#L24

KDED should probably not be restarted during installation or upgrade, and so it'll need to be identified why this is happening and if it is necessary. I don't think there's a good way to workaround this in plasma-welcome.
Comment 2 Nate Graham 2023-06-22 13:09:20 UTC
Hmm, but until the live session feature was merged yesterday, this wasn't happening. So it seems like something there changed to trigger the bug.
Comment 3 Oliver Beard 2023-06-22 13:32:56 UTC
(In reply to Nate Graham from comment #2)
> Hmm, but until the live session feature was merged yesterday, this wasn't
> happening. So it seems like something there changed to trigger the bug.

Actually, I believe it was - during the first stages of installation Welcome Center appeared. This was on the 19th, and I had figured out then that KDED was restarted.
Comment 4 David Redondo 2023-06-22 13:39:08 UTC
For me it popped up again after reboot
I do not have a plasma-welcomerc at all
Comment 5 Oliver Beard 2023-06-22 14:12:57 UTC
(In reply to David Redondo from comment #4)
> For me it popped up again after reboot
> I do not have a plasma-welcomerc at all

Fixed with https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/87.

Welcome Center would always autostart in live installer mode after merging the live session feature.

The issue with Welcome Center appearing during installation due to KDED being restarted persists.
Comment 6 Nate Graham 2023-06-22 14:21:53 UTC
Git commit 0900adab34464da2a970b9e3f5843feeb9e163ef by Nate Graham, on behalf of Oliver Beard.
Committed on 22/06/2023 at 14:21.
Pushed by ngraham into branch 'master'.

kded/daemon: Fix assuming LiveEnvironment and improve handling

LiveEnvironment, when missing, was given a default value of true instead
of false by mistake. This caused Welcome Center to always open.

M  +1    -1    src/kded/daemon.cpp

https://invent.kde.org/plasma/plasma-welcome/-/commit/0900adab34464da2a970b9e3f5843feeb9e163ef