Bug 470926 - Adopt "explicit apply" paradigm with Apply/Cancel buttons
Summary: Adopt "explicit apply" paradigm with Apply/Cancel buttons
Status: RESOLVED INTENTIONAL
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_autostart (show other bugs)
Version: 5.27.5
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-12 07:34 UTC by Guido Schmidt
Modified: 2023-07-26 15:51 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Schmidt 2023-06-12 07:34:53 UTC
SUMMARY
I wanted to inspect an autostart entry in my list that didn't have a name. Not sure what that horizontal line at the end meant, I clicked it, only to discover I just had removed the entry. (BTW: Who thinks it's a good idea to hide the button until you hover it?) Well, I didn't press the apply button yet, so nothing to worry, right? Wrong. Entry gone. 

STEPS TO REPRODUCE
1. Click the minus button of an entry.

OBSERVED RESULT
2. See the entry disappear.
3. Find out there are no apply/cancel buttons.

EXPECTED RESULT
Find apply and cancel button like in the other settings.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Opensuse Tumbleweed
KDE Plasma Version: 5.27.5
Comment 1 thenujan 2023-07-08 16:39:27 UTC
(In reply to Guido Schmidt from comment #0)

> Not sure what that horizontal line at the end meant, I clicked it
You could have simply hovered over the button for a moment to get the tooltip to reveal what it does.

> (BTW: Who thinks it's a good idea to hide the button until you hover it?) 
Plasma is not the only one using it. I have seen many websites and apps doing that and it makes the UI look better.

And I don't think adding apply, cancel buttons to this kcm make much sense anyway. It's quite hard to implement as it this kcm doesn't simply manage a config file like most of the kcms that have apply buttons. And even if it is implemented, it will make the codebase more complex for a feature that isn't really necessary. But willing to know what others think
Comment 2 Nate Graham 2023-07-25 16:07:29 UTC
I don't see a need to do this. Plenty of KCMs already use the "Instant Apply" paradigm because the "Explicit Apply" paradigm doesn't make sense there.

If there are any UX issues caused by the use of the "Explicit Apply" paradigm in this KCM, we should just fix them. And the issue described here has already been fixed for Plasma 6 by making the "remove this entry" button a red X, not an ambiguous bar/minus sign. That should make it clear what will happen when you click on it.
Comment 3 Guido Schmidt 2023-07-26 15:51:49 UTC
I wouldn't call it plenty. Only 5 out of 70 dialogs in my system settings don't have an Apply button.
- Two of them ask if you really want to apply the changes: Global Design and Online accounts.
- Game controller asks you before you start a new calibration.
I think a confirmation dialog would be appropriate for autostart, too. 

Good to know that the button issue has been addressed, though. Thanks!