Bug 470743 - Next and Previous buttons of the Media Player applet don't work
Summary: Next and Previous buttons of the Media Player applet don't work
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Media Player (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-06-07 11:29 UTC by Patrick Silva
Modified: 2023-07-15 15:34 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screen recording (1.98 MB, video/webm)
2023-06-21 14:38 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-06-07 11:29:03 UTC
STEPS TO REPRODUCE
1. play video/audio with a player controllable by the Media Player applet
2. click on the Media Player applet in the system tray
3. click on any button below the seek bar

OBSERVED RESULT
none button works

EXPECTED RESULT
all buttons should work properly

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.0
Graphics Platform: Wayland
Comment 1 David Edmundson 2023-06-07 22:24:35 UTC
This works for me. Can you check it's still an issue
Comment 2 Patrick Silva 2023-06-12 11:22:48 UTC
The bug persists on my system.
Comment 3 Justin Zobel 2023-06-13 01:14:16 UTC
I also can't replicate this with Haruna or Spotify (in Firefox).
Comment 4 Nate Graham 2023-06-21 09:09:01 UTC
Also works for me in Plasma 6 as well with those steps. Are the steps accurate? Can you attach a screen recording maybe?
Comment 5 Patrick Silva 2023-06-21 14:38:17 UTC
Created attachment 159815 [details]
screen recording
Comment 6 Bug Janitor Service 2023-07-06 03:45:18 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Nate Graham 2023-07-12 23:12:09 UTC
Everything appears to be working for me, except for the next and previous track buttons. Let's make it about that, since the way actions were implemented has been re-done since the bug report was submitted, and the original code for it is most likely no longer existent.
Comment 8 Nate Graham 2023-07-13 01:14:56 UTC
Jul 12 19:10:32 Liberator plasmashell[309918]: file:///home/nate/kde/usr6/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/ExpandedRepresentation.qml:591: TypeError: Property 'action_previous' of object AppletInterface_QML_664(0x2fa9ce0) is not a function
Jul 12 19:10:32 Liberator plasmashell[309918]: file:///home/nate/kde/usr6/share/plasma/plasmoids/org.kde.plasma.mediacontroller/contents/ui/ExpandedRepresentation.qml:591: TypeError: Property 'action_previous' of object AppletInterface_QML_664(0x2fa9ce0) is not a function
Comment 9 Bug Janitor Service 2023-07-14 18:05:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3072
Comment 10 Nate Graham 2023-07-15 15:34:02 UTC
Git commit d75188e860a6abd215550a7be43486175f2e645b by Nate Graham.
Committed on 15/07/2023 at 15:32.
Pushed by ngraham into branch 'master'.

applets/mediacontroller: fix broken actions

Broken in the Actions refactor when these invocations of the old API
weren't ported.

A simple fix would be to port these old invocations of the removed
action_thing() function calls to use root.serviceOp() instead, but that
would lead to some code duplication, so instead let's add new top-level
public functions for these things and reference those functions
consistently in all places, which fixes the bug automatically.

M  +5    -5    applets/mediacontroller/package/contents/ui/ExpandedRepresentation.qml
M  +31   -11   applets/mediacontroller/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/d75188e860a6abd215550a7be43486175f2e645b