Bug 470612 - SwipeListItem action buttons lack icons in KF6
Summary: SwipeListItem action buttons lack icons in KF6
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR major
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-06-03 21:23 UTC by Nate Graham
Modified: 2023-06-07 14:40 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/-/commit/77b16c6671a023f63acc4284b0821b50f2b83c64
Version Fixed In:

Attachments
ToolButtons with no icons (73.15 KB, image/jpeg)
2023-06-03 21:23 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-06-03 21:23:04 UTC 
Created attachment 159455 [details]
ToolButtons with no icons

See attached screenshot of the Virtual Desktops KCM.

SwipeListItem.qml has the following code to draw the toolbuttons:

>             delegate: QQC2.ToolButton {
>                 icon.name: modelData.iconName !== "" ? modelData.iconName : ""
>                 icon.source: modelData.iconSource !== "" ? modelData.iconSource : ""

Use of iconName seems fishy since that's no longer in Qt6, but I tried changing it to icon.name and it didn't fix the problem.
Comment 1 Justin Zobel 2023-06-06 06:42:01 UTC 
Can confirm.
Comment 2 Bug Janitor Service 2023-06-07 12:09:14 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1113
Comment 3 Nicolas Fella 2023-06-07 14:40:51 UTC 
Git commit 77b16c6671a023f63acc4284b0821b50f2b83c64 by Nicolas Fella.
Committed on 07/06/2023 at 12:08.
Pushed by nicolasfella into branch 'master'.

[swipelistitem] Fix icons on action buttons

M  +2    -2    src/controls/templates/SwipeListItem.qml

https://invent.kde.org/frameworks/kirigami/-/commit/77b16c6671a023f63acc4284b0821b50f2b83c64