Bug 470322 - When in Rectangular Region mode, ESC key should exit that mode and show the viewer window or "take new screenshot" window rather than quitting Spectacle
Summary: When in Rectangular Region mode, ESC key should exit that mode and show the v...
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: 23.04.1
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Noah Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-27 05:05 UTC by jonzn4SUSE
Modified: 2023-12-05 15:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 24.02
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jonzn4SUSE 2023-05-27 05:05:25 UTC
STEPS TO REPRODUCE
1. Open Spectacle
2. Hit the ESC key
3. The app closes

OBSERVED RESULT


EXPECTED RESULT
For the app not to close when hitting the ESC key.



Operating System: openSUSE Tumbleweed 20230525
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.9
Kernel Version: 6.3.2-1-default (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Xeon® CPU E3-1535M v6 @ 3.10GHz
Memory: 62.2 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics P630
Manufacturer: HP
Product Name: HP ZBook 17 G4rsion: 
Qt Version: 

ADDITIONAL INFORMATION

I noticed it after hitting Rectangle Region and then changing my mind and not wanting to take a screenshot.  So I would always hit the ESC key to get out of the select region option.
Comment 1 jonzn4SUSE 2023-05-27 05:06:11 UTC
I do see this bug, but I'll let you guys make the decision.
https://bugs.kde.org/show_bug.cgi?id=456823
Comment 2 jonzn4SUSE 2023-05-27 05:20:26 UTC
I just noticed in Leap 15.4 that Spectacle 21.12.3 also closes when hitting the ESC key.
Comment 3 Joshua Goins 2023-05-27 23:51:59 UTC
This is intentional behavior, but beginning with Spectacle 23.04 this behavior is improved because taking a screenshot has been redone. Taking a rectangular screenshot for example doesn't block every other action, you can simply switch to another mode.
Comment 4 jonzn4SUSE 2023-05-29 23:38:44 UTC
When I hit Rectangular Region and then change my mind, the ESC key is the only option to get out of that mode.  After hitting ESC, the app is closed.  In the previous version it would just take me out of the Rectangular Region mode and back to the app without having to reopen it.
Comment 5 Noah Davis 2023-05-30 02:28:38 UTC
(In reply to jonzn4SUSE from comment #4)
> When I hit Rectangular Region and then change my mind, the ESC key is the
> only option to get out of that mode.  After hitting ESC, the app is closed. 
> In the previous version it would just take me out of the Rectangular Region
> mode and back to the app without having to reopen it.

To be clear, do you only expect it to return when starting spectacle from the viewer window or new screenshot dialog or do you expect it to return to the viewer window/new screenshot dialog even when starting in rectangle capture mode? I was planning to eventually make Spectacle return to the viewer window/new screenshot dialog after pressing escape in rectangle capture mode if spectacle was started with the viewer window/new screenshot dialog.
Comment 6 jonzn4SUSE 2023-05-30 07:21:51 UTC
(In reply to Noah Davis from comment #5)
> (In reply to jonzn4SUSE from comment #4)
> > When I hit Rectangular Region and then change my mind, the ESC key is the
> > only option to get out of that mode.  After hitting ESC, the app is closed. 
> > In the previous version it would just take me out of the Rectangular Region
> > mode and back to the app without having to reopen it.
> 
> To be clear, do you only expect it to return when starting spectacle from
> the viewer window or new screenshot dialog or do you expect it to return to
> the viewer window/new screenshot dialog even when starting in rectangle
> capture mode? I was planning to eventually make Spectacle return to the
> viewer window/new screenshot dialog after pressing escape in rectangle
> capture mode if spectacle was started with the viewer window/new screenshot
> dialog.

Here is the video showing how the app worked before the current version when hitting the escape key. https://youtu.be/4qinOwGmbr4
Comment 7 Nate Graham 2023-07-04 20:41:08 UTC
Re-titling and re-opening to reflect the request, which seems reasonable given that it's a behavioral change from the older version of Spectacle. Marking it as a wishlist though, as it's not technically a bug but rather a request to change the current design. But the request seems reasonable to me.
Comment 8 jonzn4SUSE 2023-07-08 08:54:12 UTC
Very reasonable...
Comment 9 jack_sprat 2023-09-27 21:33:53 UTC
Agreed - I too have grown to expect ESC to back out of current action, not close the whole application.
Comment 10 Bug Janitor Service 2023-11-30 13:41:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/301
Comment 11 Noah Davis 2023-11-30 16:37:06 UTC
Git commit 7999bc921fcf9e04fe5a5d0d3306de7ffe1de278 by Noah Davis.
Committed on 30/11/2023 at 14:44.
Pushed by ndavis into branch 'master'.

Go back to viewer when pressing Escape in a capture window in GUI mode

Note, this does not bring back the previous screenshot. Whatever was in
the capture window will end up in the viewer window. Bringing back the
previous screenshot would require a lot more work than this, so we'll
have do that later.

M  +1    -5    src/Gui/SpectacleWindow.cpp
M  +5    -0    src/SpectacleCore.cpp

https://invent.kde.org/graphics/spectacle/-/commit/7999bc921fcf9e04fe5a5d0d3306de7ffe1de278
Comment 12 jonzn4SUSE 2023-11-30 17:43:11 UTC
Resolved...  
I open the app and hit ESC, the app still closes.  This wasn't an issue until the update.
I know it doesn't bring back the screenshot, I'm trying to get the app to stay open whenever I hit the ESC key.  That's it.  
I can install an older version openSUSE and post a video if needed.
Comment 13 Nate Graham 2023-11-30 17:44:21 UTC
The fix was just merged an hour ago, and will be included in the upcoming Spectacle 24.02 version, scheduled to be released on February 28th of next year.
Comment 14 jonzn4SUSE 2023-11-30 17:46:56 UTC
Disregard last comment.  I do see that it's working in openSUSE Leap 15.6.  I'll test Tumble when I get home.
Thanks  ;-))
Comment 15 jonzn4SUSE 2023-11-30 17:47:48 UTC
Wish we could edit or delete comments on this site.  ;-))
Comment 16 jonzn4SUSE 2023-12-05 13:28:12 UTC
I'm on openSUSE Leap 15.6 Alpha and it's running version 22.12.3.  I'm hoping you're going to bring back the same behavior as this version.
Comment 17 Noah Davis 2023-12-05 15:29:33 UTC
(In reply to jonzn4SUSE from comment #16)
> I'm on openSUSE Leap 15.6 Alpha and it's running version 22.12.3.  I'm
> hoping you're going to bring back the same behavior as this version.

This was fixed in 24.02. 22.12 is now unsupported.