Bug 470297 - Make header text selectable on Application Page
Summary: Make header text selectable on Application Page
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.27.5
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2023-05-26 15:12 UTC by `{third: "Beedell", first: "Roke"}`{.JSON5}
Modified: 2023-05-29 08:01 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/discover/-/commit/51f3a98a9587de37dcba0108e153d470039821ce
Version Fixed In: 5.27.6

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description `{third: "Beedell", first: "Roke"}`{.JSON5} 2023-05-26 15:12:33 UTC 
SUMMARY

From https://discuss.kde.org/t/how-to-copy-local-package-link-from-discover-to-clipboard/1680?u=rokejulianlockhart,

When installing a local package via #Discover, installation frequently fails because interaction is necessary at the command-line (and Discover, unlike DrKonqi, doesn't spawn a terminal as a backup when installing a package).

Consequently, when it fails with "Internal error: Installation has been aborted as directed" I want to invoke

zypper install {package}

in Konsole, but I have to manually re-navigate to the package's path, because I can't copy the path of the package to the clipboard.

STEPS TO REPRODUCE

1. Attempt to install an unsigned package using OpenSUSE Tumbleweed.

OBSERVED RESULT

I can't copy the path to the package. It merely appears as a tooltip.

EXPECTED RESULT

I should be able to copy the path to the package from Discover, or better yet, open it preselected in Dolphin.

SOFTWARE/OS VERSIONS

Operating System: openSUSE Tumbleweed 20230525
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.107.0
Qt Version: 5.15.9
Kernel Version: 6.3.2-1-default (64-bit)

ADDITIONAL INFORMATION

https://discuss.kde.org/t/how-to-copy-local-package-link-from-discover-to-clipboard/1680/2?u=rokejulianlockhart

Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 31.2 GiB of RAM
Graphics Processor: AMD Radeon RX 5700
Comment 1 Bug Janitor Service 2023-05-28 06:29:04 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/556
Comment 2 Joshua Goins 2023-05-29 08:00:42 UTC 
Git commit a07f6a9c77aae757d4cc72639fc7bf41f28b5018 by Joshua Goins, on behalf of Nate Graham.
Committed on 29/05/2023 at 03:14.
Pushed by ngraham into branch 'master'.

ApplicationPage: make heading/short description text selectable

The main text is already selectable, and the heading/short description
text is used to display the package path for locally-downloaded
packages, which make sense to be able to select. So for those reasons,
make it also selectable.

This entails porting away from Kirigami.Heading and using
Kirigami.SelectableLabel, which means we need to do a small amount of
work to match the visual styling and accessibility metadata that were
previously provided by Kirigami.Heading.
FIXED-IN: 5.27.6

M  +12   -5    discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/-/commit/a07f6a9c77aae757d4cc72639fc7bf41f28b5018
Comment 3 Nate Graham 2023-05-29 08:01:16 UTC 
Git commit 51f3a98a9587de37dcba0108e153d470039821ce by Nate Graham.
Committed on 29/05/2023 at 08:01.
Pushed by ngraham into branch 'Plasma/5.27'.

ApplicationPage: make heading/short description text selectable

The main text is already selectable, and the heading/short description
text is used to display the package path for locally-downloaded
packages, which make sense to be able to select. So for those reasons,
make it also selectable.

This entails porting away from Kirigami.Heading and using
Kirigami.SelectableLabel, which means we need to do a small amount of
work to match the visual styling and accessibility metadata that were
previously provided by Kirigami.Heading.
FIXED-IN: 5.27.6


(cherry picked from commit a07f6a9c77aae757d4cc72639fc7bf41f28b5018)

M  +12   -5    discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/-/commit/51f3a98a9587de37dcba0108e153d470039821ce