Bug 470211 - Double click to make selection
Summary: Double click to make selection
Status: RESOLVED FIXED
Alias: None
Product: xdg-desktop-portal-kde
Classification: Plasma
Component: general (show other bugs)
Version: 5.27.5
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2023-05-24 12:28 UTC by iodreamify
Modified: 2024-01-21 13:43 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/3c0f95bb109398141db701eea4102daa165bae97
Version Fixed In: 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description iodreamify 2023-05-24 12:28:11 UTC 
SUMMARY
Presently to start the sharing you have to make a selection and press the Share button. It would be much easier to quickly select the type of capture inside the dialog if it were possible to double click on the element and have the sharing start immediately.  

STEPS TO REPRODUCE
1. Open OBS on Wayland
2. Add a Pipewire screen capture source
3. Double click an element from the Kde Portal  

OBSERVED RESULT
The element only gets selected and deselected

EXPECTED RESULT
The element is selected and the window closes, sharing starts.

Operating System: Fedora Linux 38
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.9
Kernel Version: 6.2.15-300.fc38.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i3-2310M CPU @ 2.10GHz
Comment 1 Nate Graham 2023-05-24 20:32:31 UTC 
Would probably also make sense for the App Chooser dialog.
Comment 2 iodreamify 2023-05-24 20:35:46 UTC 
Alternatively, the buttons could behave like buttons requiring only one click. But i'm not sure if this wouldn't increase accidental misclicks and lower security. And also how easy single click would be to implement, especially if the dialogs already have a sort of confirmation button.
Comment 3 Nate Graham 2023-05-24 20:38:15 UTC 
For the screen chooser dialog, multi-selection can be allowed, and I think it might be awkward to have the buttons react differently depending on the implementation detail of whether the app allows multi-selection.

For the App Chooser dialog, we can certainly do it, though.
Comment 4 fanzhuyifan 2024-01-14 07:23:08 UTC 
IMO from a UX perspective it might be reasonable to always make double click select the current item and confirm (with just the current item selected), even when multi-selection is allowed.
Comment 5 Bug Janitor Service 2024-01-14 07:41:25 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/261
Comment 6 fanzhuyifan 2024-01-17 19:09:53 UTC 
Git commit 47a9d968e09e60e99b0ba888e5ac77f0969d7334 by Yifan Zhu.
Committed on 14/01/2024 at 08:37.
Pushed by ngraham into branch 'master'.

ScreenChooserDialog: doubleclick to select&confirm

Make doubleclick always select (only) the clicked item and confirm
FIXED-IN: 6.0

M  +14   -0    src/ScreenChooserDialog.qml

https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/47a9d968e09e60e99b0ba888e5ac77f0969d7334
Comment 7 Nate Graham 2024-01-17 19:12:39 UTC 
Git commit 3c0f95bb109398141db701eea4102daa165bae97 by Nate Graham, on behalf of Yifan Zhu.
Committed on 17/01/2024 at 20:10.
Pushed by ngraham into branch 'Plasma/6.0'.

ScreenChooserDialog: doubleclick to select&confirm

Make doubleclick always select (only) the clicked item and confirm
FIXED-IN: 6.0


(cherry picked from commit 47a9d968e09e60e99b0ba888e5ac77f0969d7334)

M  +14   -0    src/ScreenChooserDialog.qml

https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/3c0f95bb109398141db701eea4102daa165bae97