Bug 470166 - Solver does not work with golf
Summary: Solver does not work with golf
Status: RESOLVED FIXED
Alias: None
Product: kpat
Classification: Applications
Component: solver (show other bugs)
Version: 23.04.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-23 14:48 UTC by Brian Kaye
Modified: 2023-07-11 20:15 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/games/kpat/-/commit/65ed6d5270b6d77ac4f57218f4a5db24b621135a
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Kaye 2023-05-23 14:48:34 UTC 
SUMMARY
Solver does not work when running golf.

STEPS TO REPRODUCE
1. Run golf game with solver enabled.
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Brian Kaye 2023-06-09 21:58:46 UTC 
If you start  the golf game after starting kpat, the solver seems to work correctly. If however you start the golf game after running another of the kpat games, the solver does not work. It continually  reports that  it cannot determine if the game is winnable.  You an ask for a re-deal but the response  from the solver is always the same. All other games that I tried all seem to work with the solver.
Comment 2 Stephan Kulow 2023-06-10 06:51:01 UTC 
Interesting ...
Comment 3 Stephan Kulow 2023-06-10 07:10:30 UTC 
Thanks for the report, it was a regression from February sprint: https://invent.kde.org/games/kpat/-/merge_requests/49
Comment 4 Albert Astals Cid 2023-06-12 21:13:41 UTC 
Git commit 58221b51b1460b9a276cae378a8f07e08bc19ab3 by Albert Astals Cid, on behalf of Stephan Kulow.
Committed on 12/06/2023 at 21:13.
Pushed by aacid into branch 'master'.

Reinit Golf solver correctly after switching games

M  +1    -1    src/patsolve/golfsolver.cpp

https://invent.kde.org/games/kpat/-/commit/58221b51b1460b9a276cae378a8f07e08bc19ab3
Comment 5 Albert Astals Cid 2023-06-12 21:39:17 UTC 
Git commit 65ed6d5270b6d77ac4f57218f4a5db24b621135a by Albert Astals Cid, on behalf of Stephan Kulow.
Committed on 12/06/2023 at 21:38.
Pushed by aacid into branch 'release/23.04'.

Reinit Golf solver correctly after switching games
(cherry picked from commit 58221b51b1460b9a276cae378a8f07e08bc19ab3)

M  +1    -1    src/patsolve/golfsolver.cpp

https://invent.kde.org/games/kpat/-/commit/65ed6d5270b6d77ac4f57218f4a5db24b621135a
Comment 6 Brian Kaye 2023-07-11 18:52:24 UTC 
The fedora rpms do not seem to have picked up the change to fix this problem. How do I verify which solver version is being used?
Comment 7 Stephan Kulow 2023-07-11 18:54:44 UTC 
Does the version say v23.04.3?
Comment 8 Brian Kaye 2023-07-11 19:46:53 UTC 
(In reply to Stephan Kulow from comment #7)
> Does the version say v23.04.3?

No. It says 23.04.2. How do I tell which version of the solver is in it. Or do I have to wait for fedora to pick it up or somehow encourage them to do so?
Comment 9 Stephan Kulow 2023-07-11 20:15:45 UTC 
well, if it's not ..3, it has the broken solver.