Bug 470086 - Incorrect "Back" header after nested password was selected
Summary: Incorrect "Back" header after nested password was selected
Status: RESOLVED FIXED
Alias: None
Product: plasma-pass
Classification: Unmaintained
Component: General (other bugs)
Version First Reported In: 1.2.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Vrátil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-21 14:57 UTC by WiseLord
Modified: 2023-06-05 20:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Video with the issue (1.30 MB, video/mp4)
2023-05-21 14:57 UTC, WiseLord
Details
Patch with fix for the issue (1.15 KB, patch)
2023-05-23 09:14 UTC, WiseLord
Details

Note You need to log in before you can comment on or make changes to this bug.
Description WiseLord 2023-05-21 14:57:34 UTC
Created attachment 159164 [details]
Video with the issue

SUMMARY
***
Plasma-pass "Back" button shows incorrect path to top-level layer, after nested password was selected.
***

STEPS TO REPRODUCE
1. Select some nested (not top-level) password in widget (e.g., Dir1/Dir2/Dir3/password)
2. Repeat 1st step several times
3. See incorrect "back" path in step 2.

OBSERVED RESULT

Incorrect "Back" path shown

EXPECTED RESULT

1 level up path shown

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo Linux 2.13
KDE Plasma Version:  5.27.4
KDE Frameworks Version:  5.104.0
Qt Version: 5.15.9

ADDITIONAL INFORMATION

Video with the issue: https://youtu.be/hRCtvdDzpSg (or see the attachment)
Comment 1 WiseLord 2023-05-23 09:14:01 UTC
Created attachment 159194 [details]
Patch with fix for the issue

Looked at source code and found a solution that looks working for me.
Comment 2 Andreas Sturmlechner 2023-05-23 17:35:44 UTC
Please consider creating a MR on invent.kde.org for plasma-pass project, which is much more likely to get attention than a patch attachment in bugzilla.
Comment 3 Bug Janitor Service 2023-05-29 10:29:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-pass/-/merge_requests/12
Comment 4 Daniel Vrátil 2023-06-05 20:44:26 UTC
Git commit a37044fcd03d8dedb87f86322499e4a5bc195092 by Daniel Vrátil, on behalf of Uladzimir Bely.
Committed on 05/06/2023 at 20:44.
Pushed by dvratil into branch 'master'.

Clear path on widget when it goes to non-expanded state

This fixes the issue with incorrect path shown in case widget
is used in system tray.

Signed-off-by: Uladzimir Bely <wiselord1983@gmail.com>

M  +4    -0    package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-pass/-/commit/a37044fcd03d8dedb87f86322499e4a5bc195092