Bug 470066 - Dark themes make it impossible to see if a photograph is geo‐located
Summary: Dark themes make it impossible to see if a photograph is geo‐located
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: 8.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-20 22:23 UTC by maison
Modified: 2023-07-10 20:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.1.0
Sentry Crash Report:


Attachments
default (48.42 KB, image/png)
2023-07-10 19:19 UTC, maison
Details
black body (48.34 KB, image/png)
2023-07-10 19:19 UTC, maison
Details

Note You need to log in before you can comment on or make changes to this bug.
Description maison 2023-05-20 22:23:55 UTC
STEPS TO REPRODUCE
1. Set one of the several dark or grey themes.
2. Look at the main interface on the thumbnails of images that have a geocoding tag globe icon.

OBSERVED RESULT
It’s nearly impossible to see this globe; it’s too dim.

EXPECTED RESULT
Like in the default white interface, make the globe visible in the right upper corner.

SOFTWARE/OS VERSIONS
Windows: 

ADDITIONAL INFORMATION
Comment 1 caulier.gilles 2023-05-21 05:30:21 UTC
Git commit 7cc7f53b39c9f374ab4a5ef297b41b08dbed062a by Gilles Caulier.
Committed on 21/05/2023 at 05:17.
Pushed by cgilles into branch 'master'.

Start to support Breeze style from Plasma desktop in digiKam bundles to prevent a broken rendereing of widgets and icons when breeze theme is used.
Intentional: this do not includes decoration and kcm parts, only the core libs plus theme files --> these implementations must be available as a KF5 component, not in Plasma
A KDE application ALSO work under MacOS and Windows, not ONLY Linux. As usual, reduce the puzzle please.
Related: bug 385148, bug 414428, bug 406408

M  +67   -2    project/bundles/3rdparty/CMakeLists.txt [INFRASTRUCTURE] [INFRASTRUCTURE] [INFRASTRUCTURE]
A  +98   -0    project/bundles/3rdparty/ext_breeze/CMakeLists.txt [INFRASTRUCTURE] [INFRASTRUCTURE] [INFRASTRUCTURE]
A  +32   -0    project/bundles/3rdparty/ext_breeze/breeze-common-rules.patch
M  +4    -1    project/bundles/appimage/02-build-extralibs.sh
M  +5    -1    project/bundles/appimage/config.sh [INFRASTRUCTURE]
M  +5    -1    project/bundles/macports/02-build-extralibs.sh
M  +7    -1    project/bundles/macports/config.sh [INFRASTRUCTURE] [INFRASTRUCTURE] [INFRASTRUCTURE]
M  +5    -1    project/bundles/mxe/02-build-extralibs.sh
M  +6    -0    project/bundles/mxe/config.sh [INFRASTRUCTURE] [INFRASTRUCTURE] [INFRASTRUCTURE]
A  +29   -0    project/scripts/bootstrap-breeze.sh

https://invent.kde.org/graphics/digikam/commit/7cc7f53b39c9f374ab4a5ef297b41b08dbed062a
Comment 2 caulier.gilles 2023-05-21 06:32:24 UTC
Git commit 0b8d82b49be57e979291d1e83ec49fc828818f54 by Gilles Caulier.
Committed on 21/05/2023 at 06:30.
Pushed by cgilles into branch 'master'.

adjust patch to Plasma v5.27.5
Related: bug 385148, bug 414428, bug 406408

M  +7    -7    project/bundles/3rdparty/ext_breeze/breeze-common-rules.patch

https://invent.kde.org/graphics/digikam/commit/0b8d82b49be57e979291d1e83ec49fc828818f54
Comment 3 caulier.gilles 2023-05-21 08:04:11 UTC
Git commit 9e8718d743bbbb588fef78ea48b28d8257eb5000 by Gilles Caulier.
Committed on 21/05/2023 at 08:01.
Pushed by cgilles into branch 'master'.

Enable widget styles support under MacOS
Related: bug 385148, bug 406408, bug 414428, bug 279183, bug 413748, bug 198201, bug 410501, bug 262702

M  +1    -0    project/bundles/macports/03-build-digikam.sh

https://invent.kde.org/graphics/digikam/commit/9e8718d743bbbb588fef78ea48b28d8257eb5000
Comment 4 caulier.gilles 2023-05-22 05:09:26 UTC
digiKam 8.1.0 Installer will provide the Breeze widgets style to render properly all the GUI under Microsoft Windows.

Select Breeze style/Icons set in Setup/Miscs dialog page.

https://i.imgur.com/04rBuV3.png

Best

Gilles Caulier
Comment 5 caulier.gilles 2023-05-22 05:38:06 UTC
Git commit da88685a35b3d809bca11a8c65582015b9ce4f55 by Gilles Caulier.
Committed on 22/05/2023 at 05:34.
Pushed by cgilles into branch 'master'.

Switch to Breeze widgets style by default
Related: bug 365262, bug 221065, bug 414428, bug 279183, bug 381855, bug 262702, bug 198201, bug 385148, bug 436259, bug 413748, bug 413879, bug 406408, bug 410501

M  +5    -5    NEWS
M  +2    -2    core/libs/settings/applicationsettings.cpp
M  +2    -2    core/showfoto/main/showfotosettings.cpp
M  +1    -1    core/tests/video/qtav/avplayer/main/MainWindow.cpp

https://invent.kde.org/graphics/digikam/commit/da88685a35b3d809bca11a8c65582015b9ce4f55
Comment 6 caulier.gilles 2023-05-22 06:01:37 UTC
Git commit a7c475aa49fea92d8b7735b7f39381b18bb58fe9 by Gilles Caulier.
Committed on 22/05/2023 at 05:58.
Pushed by cgilles into branch 'master'.

digiKam online documentation: Recommend "Brezze" Widgets style and icons-set instead "Fusion" for all desktop.
Related: bug 365262, bug 221065, bug 414428, bug 279183, bug 381855, bug 262702, bug 198201, bug 385148, bug 436259, bug 413748, bug 413879, bug 406408, bug 410501

M  +2    -2    setup_application/miscs_settings.rst

https://invent.kde.org/documentation/digikam-doc/commit/a7c475aa49fea92d8b7735b7f39381b18bb58fe9
Comment 7 Maik Qualmann 2023-05-22 16:55:13 UTC
Git commit 581c434b6d2887074bdfe4097d5b8a456d63acfd by Maik Qualmann.
Committed on 22/05/2023 at 16:53.
Pushed by mqualmann into branch 'master'.

draw a transparent background for the geolocation icon

M  +7    -3    core/libs/widgets/itemview/itemviewdelegate.cpp

https://invent.kde.org/graphics/digikam/commit/581c434b6d2887074bdfe4097d5b8a456d63acfd
Comment 8 maison 2023-05-22 21:38:14 UTC
Thanks Gilles! This is the quickest fix I’ve ever seen on the bug reports I submitted for any software.
Comment 9 maison 2023-07-10 19:19:26 UTC
Created attachment 160227 [details]
default
Comment 10 maison 2023-07-10 19:19:46 UTC
Created attachment 160228 [details]
black body
Comment 11 maison 2023-07-10 19:20:12 UTC
Unfortunately this bug is still not resolved in 8.1.0.
Compare the default theme with some dark ones. Most of the dark ones still have unnoticeable icons.
Comment 12 Maik Qualmann 2023-07-10 20:00:07 UTC
If you change the color theme from light <==> dark, you need to restart digiKam for the correct icons to be used. The geo icon is no longer drawn transparently, which also limits visibility.

Maik
Comment 13 maison 2023-07-10 20:02:28 UTC
Indeed, thanks Mark for reminding me what the dialogue box was indicating.