Bug 469727 - Support setting Window Decoration BorderSize via Global Theme
Summary: Support setting Window Decoration BorderSize via Global Theme
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_lookandfeel (show other bugs)
Version: 5.27.4
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-14 06:31 UTC by doncbugs
Modified: 2023-06-02 17:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
A global theme to demonstrate settings being applied (807 bytes, application/zip)
2023-05-14 06:31 UTC, doncbugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description doncbugs 2023-05-14 06:31:57 UTC
Created attachment 158926 [details]
A global theme to demonstrate settings being applied

SUMMARY
It is a bit confusing as to what goes where since different settings work in different, but similar-looking files. E.g. The "defaults" file in the Global Theme's "contents" and the "defaults" inside its "layouts" folder.

STEPS TO REPRODUCE
1. Create a Global theme (a dummy theme named "w" is attached, it is extracted to ~/.local/share/plasma/look-and-feel/)
2. Inside the theme's "contents">"layouts" folder, create a file named "defaults"
3. Add the following to the file:

[kwinrc][org.kde.kdecoration2]
ButtonsOnRight=SFM
BorderSize=Tiny

4. Save the file and apply the Global Theme with its layout

OBSERVED RESULT
The buttons are changed, but the border size remains Normal.

EXPECTED RESULT
The buttons should change and the border size should be set (to Tiny in this case).

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.8
Kernel Version: 5.19.0-38-generic (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
This bug may be in the wrong place.
Comment 1 Nate Graham 2023-05-18 20:02:30 UTC
Working on this.
Comment 2 Bug Janitor Service 2023-05-18 21:23:23 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2936
Comment 3 Nate Graham 2023-06-02 17:33:25 UTC
Git commit 66370b3d15448dab3dd86ee1b80b0c8f4a78f502 by Nate Graham.
Committed on 02/06/2023 at 17:02.
Pushed by ngraham into branch 'master'.

kcms/lookandfeel: support "BorderSize" key in global themes

It will be considered an appearance setting.
FIXED-IN: 6.0

M  +16   -0    kcms/lookandfeel/lookandfeelmanager.cpp
M  +4    -2    kcms/lookandfeel/lookandfeelmanager.h
M  +2    -1    kcms/lookandfeel/ui/MoreOptions.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/66370b3d15448dab3dd86ee1b80b0c8f4a78f502