Bug 469602 - Small enhancements adblock.html
Summary: Small enhancements adblock.html
Status: REPORTED
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (show other bugs)
Version: 23.04.0
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-10 23:29 UTC by Schimon Jehudah
Modified: 2023-05-17 06:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
userscript to redesign adblock.html (1.32 KB, text/javascript)
2023-05-10 23:29 UTC, Schimon Jehudah
Details
Card style (1.27 KB, text/html)
2023-05-10 23:31 UTC, Schimon Jehudah
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Schimon Jehudah 2023-05-10 23:29:12 UTC
Created attachment 158843 [details]
userscript to redesign adblock.html

Attached files with ui suggestions
Comment 1 Schimon Jehudah 2023-05-10 23:31:33 UTC
Created attachment 158844 [details]
Card style
Comment 2 Juraj 2023-05-16 08:05:01 UTC
Hello,

Thank you for the idea, but this requires a bit more work.
I would prefer to have all html pages follow the same style and look similar to some extend.
Also think about the "dark" variant which was added in latest release.

Best regards,
Juraj.
Comment 3 Schimon Jehudah 2023-05-16 16:22:39 UTC
> Thank you for the idea, but this requires a bit more work.

Please do let me know if you want to delegate to me tasks related to this.

> I would prefer to have all html pages follow the same style and look similar to some extend.

Yes, this is what I want too.
Comment 4 Juraj 2023-05-17 06:25:16 UTC
(In reply to Schimon Jehudah from comment #3)
> Please do let me know if you want to delegate to me tasks related to this.

OK, there are multiple internal html pages in Falkon.
- falkon:about - src/lib/data/html/about.html
- falkon:config - src/lib/data/html/config.html
- falkon:start - src/lib/data/html/start.html
- falkon:restore - src/lib/data/html/restore.html (when browser crashes and is opened again, depends on some internal settings as well)

- src/lib/data/html/tabcrash.html - When rendering process is terminated signal received from Qt (QWebEnginePage::renderProcessTerminated)
- src/lib/adblock/data/adblock.html - When some page is blocked by adblock, should properly work with Falkon 23.04.x
- src/plugins/VerticalTabs/data/group.html - Vertical tabs, hold the "+" button on the bottom for bit longer and menu "Add New Group" appears, click on it and it will show this page; there is also an index.html in this folder which I believe is unused.

I recommend using data from lates falkon code or release (23.04.x) and also testing the dark theme variant.
The dark variant can be forced by changing the environmental variable:
> QTWEBENGINE_CHROMIUM_FLAGS=--force-dark-mode

PS: keep it simple :)