Bug 469425 - TimlineView breaks chatbox refs
Summary: TimlineView breaks chatbox refs
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-06 18:44 UTC by James Graham
Modified: 2023-05-07 17:36 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/network/neochat/commit/bfdca9ca9e1ad63e4319b1660fce80e196ac8473
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description James Graham 2023-05-06 18:44:50 UTC 
SUMMARY
***
https://invent.kde.org/network/neochat/-/merge_requests/873 seems to have broken all the items that reference chatBox in TimelineView.qml. This means you can jump to the last unread message for example.
Comment 1 Bug Janitor Service 2023-05-07 07:37:35 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/968
Comment 2 Tobias Fella 2023-05-07 17:36:08 UTC 
Git commit bfdca9ca9e1ad63e4319b1660fce80e196ac8473 by Tobias Fella.
Committed on 07/05/2023 at 16:17.
Pushed by tfella into branch 'master'.

Fix regressions from RoomPage refactoring

Fixes 581
Related: bug 469427

M  +0    -1    src/models/messageeventmodel.cpp
M  +9    -0    src/qml/Component/ChatBox/ChatBar.qml
M  +30   -0    src/qml/Component/Timeline/TimelineContainer.qml
M  +14   -41   src/qml/Component/TimelineView.qml
M  +7    -2    src/qml/Page/RoomPage.qml

https://invent.kde.org/network/neochat/commit/bfdca9ca9e1ad63e4319b1660fce80e196ac8473