Bug 469326 - Green/white tick are too far in activity "Letter in which word"
Summary: Green/white tick are too far in activity "Letter in which word"
Status: RESOLVED FIXED
Alias: None
Product: gcompris
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR minor
Target Milestone: ---
Assignee: animtim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-03 19:33 UTC by Alexey
Modified: 2023-05-09 18:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
gcompris activity "Letter in which word" with ticks (199.04 KB, image/png)
2023-05-03 19:33 UTC, Alexey
Details
gcompris with installed "qt5-image-formats-plugins", activity "Letter in which word" (383.05 KB, image/png)
2023-05-09 18:43 UTC, Alexey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2023-05-03 19:33:04 UTC
Created attachment 158671 [details]
gcompris activity "Letter in which word" with ticks

SUMMARY

I use package gcompris-qt from Devuan testing repository.
In activity "Letter in which word", when I select words, green ticks are placed too far from the word.
It would be great to place ticks closer to the selected word, or maybe just highlight selected words instead of using ticks (or even both).

STEPS TO REPRODUCE
1. Choose activity "Letter in which word".
2. Click on any word.
3. Observe green/white tick.

OBSERVED RESULT

Ticks are too far from selected words.

EXPECTED RESULT

The selected words has ticks near, or words are highlighted as an alternative.

SOFTWARE/OS VERSIONS

gcompris-qt: 3.1-2.
Linux/KDE Plasma: Devuan 5 daedalus/ceres (based on Debian 12 bookworm).
Desktop environment: XFCE 4.18.2.
KDE Plasma Version: -
KDE Frameworks Version: -
Qt Version: 5.15.8

ADDITIONAL INFORMATION
-
Comment 1 animtim 2023-05-04 13:33:14 UTC
I'll look at this soon.
Comment 2 animtim 2023-05-09 11:49:19 UTC
Git commit b8144221c210077be018e6d7f7d1efc9fa6d16fd by Timothée Giet.
Committed on 09/05/2023 at 11:44.
Pushed by timotheegiet into branch 'master'.

letter-in-word, fix selection marker too far from word

Replace tick selection marker (which was too far from the word) with an orange
border highlight.

Adjust cards size and spacing to avoid overlap and improve readability.

M  +11   -13   src/activities/letter-in-word/Card.qml
M  +2    -1    src/activities/letter-in-word/LetterInWord.qml

https://invent.kde.org/education/gcompris/commit/b8144221c210077be018e6d7f7d1efc9fa6d16fd
Comment 3 animtim 2023-05-09 12:05:11 UTC
Actually, after looking at the attached screenshot, it shows a different issue: there should be images on top of the words, and the tick is on the top-left corner of the images... I guess the package in Devuan testing is missing the dependency to load webp images (qt5-image-formats-plugins in debian), you should report that issue to the packager of that distribution.

Anyway I've changed the tick with an orange border highlight around the text background, which looks better in any case.
Comment 4 Alexey 2023-05-09 18:43:09 UTC
Created attachment 158805 [details]
gcompris with installed "qt5-image-formats-plugins", activity "Letter in which word"

I've installed a package `qt5-image-formats-plugins` and now I see pictures together with words.
I will try to create a bugreport for maintainers.