Bug 469217 - 23.04.0 is leading to "INVALID" renders and corrupted files
Summary: 23.04.0 is leading to "INVALID" renders and corrupted files
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 23.04.0
Platform: Ubuntu Linux
: NOR critical
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-01 04:22 UTC by Stephen Fluin
Modified: 2023-11-17 03:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Fluin 2023-05-01 04:22:44 UTC
SUMMARY

This release seems really really broken to me and I've been a long time Kdenlive user. :( 

My symptoms are that all of my renders are creating files of the correct length with only the word "INVALID" rendered to screen. example: https://youtu.be/31ke4VWF4F0. When I open the file to try to debug/correct, it's showing up as "could not recover corrupted file".

STEPS TO REPRODUCE / My Story
I've edited the same video twice from scratch unsuccessfully and I'm feeling very frustrated. The first time on Windows 11 (23.04.0), but then I noticed that the rendered output was the right length but only contained the word "INVALID" and no valid audio (https://youtu.be/rWa6eYiOhMU). When I tried to load the kdenlive file on Windows later, I couldn't. I tried loading it on my linux setup and I got "could not recover corrupted file" there as well when attempting to load it. I gave up on that file, edited again from scratch, and everything seemed to be working. I rendered the file out and closed Kdenlive only to notice that the video rendered "INVALID" again. When I tried opening this new file on any operating system, I'm getting the same "could not recover corrupted file" error. I am using Kubuntu 23.04 (Lunar Lobster). I have tried originally with 4:23.04.0-0~ubuntu22.10.1 then updated to 23.04.0-6~ubuntu23.04.1. I also attempted to run the app-image versionkdenlive-23.04.0a-x86_64.AppImage .

Kdenlive file is here: https://gist.github.com/StephenFluin/c5a2c06d4f4db2804423cfbe93b3f056
Scrollback from attempting to load the file: https://gist.github.com/StephenFluin/8e66793008392d2b7bb428c45c0b6489

My video contains .mkv h264 videos from my phone, GoPro Hero 11 mp4 files (loaded via LRV proxy), and Canon R5 mp4 files, all at 4k60fps.

OBSERVED RESULT
Previously created files can't be loaded, renders are "INVALID".


EXPECTED RESULT
I can load past projects and renders contain the clips as previewed.


SOFTWARE/OS VERSIONS
Windows: 11
Linux/KDE Plasma:  Kubuntu 23.04 (Lunar Lobster)
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.0-20-generic (64-bit)
Graphics Platform: X11
Processors: 32 × AMD Ryzen 9 5950X 16-Core Processor
Memory: 94.2 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 3090/PCIe/SSE2
Manufacturer: ASUS

ADDITIONAL INFORMATION
Comment 1 Julius Künzel 2023-05-01 21:01:40 UTC
Hi Stephen,

thanks for your report and sorry, you're having trouble. We published a hotfix release yesterday, which might fix your issue. See https://kdenlive.org/en/2023/04/23-04-0a-hotfix-release/

Please tell us if the issue still exists with hotfix release. I can promise you we are working hard to fix remaining bugs introduced by the new nested timeline feature. If it is essential to you to have the most stable version of Kdenlive a general recommendation would be to use *.3 (bugfix) release as they are the most stable ones, while *.0 releases contain new features which are more likely to introduce regressions that have not been uncovered yet.

Please remember to set the correct bug status when you answer (either back to REPORTED or to RESOLVED CLOSE)
Comment 2 Stephen Fluin 2023-05-01 22:10:49 UTC
I can confirm it was still happening with the hotfix release, I was using AppImage kdenlive-23.04.0a-x86_64.AppImage .

(In reply to Julius Künzel from comment #1)
> Hi Stephen,
> 
> thanks for your report and sorry, you're having trouble. We published a
> hotfix release yesterday, which might fix your issue. See
> https://kdenlive.org/en/2023/04/23-04-0a-hotfix-release/
> 
> Please tell us if the issue still exists with hotfix release. I can promise
> you we are working hard to fix remaining bugs introduced by the new nested
> timeline feature. If it is essential to you to have the most stable version
> of Kdenlive a general recommendation would be to use *.3 (bugfix) release as
> they are the most stable ones, while *.0 releases contain new features which
> are more likely to introduce regressions that have not been uncovered yet.
> 
> Please remember to set the correct bug status when you answer (either back
> to REPORTED or to RESOLVED CLOSE)
Comment 3 Jean-Baptiste Mardelle 2023-05-04 11:52:08 UTC
Thanks for your report and sorry for this. The bug causing this corruption has now been identified and is fixed in git:
https://invent.kde.org/multimedia/kdenlive/-/commit/b382ad3a3b010564127ac7c33823fc98ff580e0c

I am trying to see if I can make Kdenlive recover the corrupted projects like the one you attached, will keep you informed
Comment 4 Jean-Baptiste Mardelle 2023-05-04 19:43:39 UTC
Git commit 2eecb82e109949dbeb8137b4b5f83ac30cd65438 by Jean-Baptiste Mardelle.
Committed on 04/05/2023 at 19:43.
Pushed by mardelle into branch 'release/23.04'.

Fix 23.04.0 corrupted files on opening

M  +7    -3    src/bin/projectitemmodel.cpp
M  +5    -3    src/bin/projectitemmodel.h
M  +53   -6    src/doc/documentchecker.cpp
M  +4    -0    src/doc/documentchecker.h
M  +2    -3    src/project/projectmanager.cpp
M  +5    -1    src/timeline2/model/builders/meltBuilder.cpp
M  +0    -9    src/timeline2/model/clipmodel.cpp
M  +0    -1    src/timeline2/model/clipmodel.hpp

https://invent.kde.org/multimedia/kdenlive/commit/2eecb82e109949dbeb8137b4b5f83ac30cd65438
Comment 5 Jean-Baptiste Mardelle 2023-05-04 19:47:57 UTC
Ok, with my last commit you should be able to recover the corrupted project file by opening. The fix will be in tomorrow's Kdenlive daily development AppImage (build #574) at:
https://binary-factory.kde.org/view/AppImage/job/Kdenlive_Nightly_appimage-centos7/

Would be great if you can test tomorrow or whenever possible to confirm the fix.
Comment 6 Stephen Fluin 2023-05-05 19:06:52 UTC
The errors have changed, but not been fixed.

Using kdenlive-master-574-linux-gcc-x86_64.AppImage, and the same project file as above.

When I try to load the file I get a sequence of 3 errors that result in an empty project.

Screenshots here: https://photos.app.goo.gl/uys4bokQtyXKo8h1A

1. '"<tractor>" the project contains missing clips or files'
2. 'Found an invalid sequence clip in Bin'
3. 'Could not recover corrupted file'
Comment 7 Jean-Baptiste Mardelle 2023-05-07 09:33:18 UTC
Git commit 6e4433cff01d775251794425d34b531ae3522039 by Jean-Baptiste Mardelle.
Committed on 07/05/2023 at 09:23.
Pushed by mardelle into branch 'release/23.04'.

Do our best to recover 23.04.0 corrupted project files

M  +93   -7    src/doc/documentchecker.cpp
M  +1    -1    src/doc/documentchecker.h
M  +4    -0    src/project/projectmanager.cpp

https://invent.kde.org/multimedia/kdenlive/commit/6e4433cff01d775251794425d34b531ae3522039
Comment 8 farid 2023-10-18 12:10:51 UTC
Hello Stephen, can you still reproduce this with the latest appimage?
Comment 9 Bug Janitor Service 2023-11-02 03:45:41 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2023-11-17 03:45:57 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!