Bug 468818 - "Take New Screenshot/Screen Recording" labels are unnecessary when tab bar is visible
Summary: "Take New Screenshot/Screen Recording" labels are unnecessary when tab bar is...
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: 23.04.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Noah Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-22 16:40 UTC by PK
Modified: 2023-04-25 22:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 23.04.1
Sentry Crash Report:


Attachments
The "Take a new screenshot" seems redundant and distracting (284.08 KB, image/png)
2023-04-22 16:40 UTC, PK
Details
The "New screen recording" seems redundant and distracting (262.99 KB, image/png)
2023-04-22 16:41 UTC, PK
Details
"ook" en "vertraging"... (100.55 KB, image/jpeg)
2023-04-25 06:31 UTC, PK
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PK 2023-04-22 16:40:05 UTC
Created attachment 158329 [details]
The "Take a new screenshot" seems redundant and distracting

SUMMARY
***

***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 PK 2023-04-22 16:41:25 UTC
Created attachment 158330 [details]
The "New screen recording" seems redundant and distracting
Comment 2 PK 2023-04-22 16:47:18 UTC
In my opinion the "Take a new screenshot" and "New screen recording" (red understriped in the two attachments) in the new user interface are distracting and redundant. The two tabs are in my opinion more than clear enough.
Comment 3 Nate Graham 2023-04-24 19:40:29 UTC
What you say makes some sense, but the tabs aren't always shown; on X11 where screen recording isn't supported (It's a Wayland-only feature), the label wouldn't be redundant. Perhaps we can remove them on Wayland though.
Comment 4 PK 2023-04-25 04:51:03 UTC
That would be great!
Comment 5 PK 2023-04-25 06:31:15 UTC
Created attachment 158409 [details]
"ook" en "vertraging"...

ook:
Ik snap dat je zo dicht mogelijk bij het Engelstalig orrigineel wilt blijven met je vertaling. Daardoor is het te lange "Muisaanwijzer ook meenemen" eenvoudig in te korten door het woordje "ook" weg te laten; ik zie in het Engelstalige orrigineel nergens "also" staan.
Vertraging:
Het woord "Vertraging" zou misschien door "wacht" vertaald kunnen worden. Het is immers niet gezegd of het woord "Delay" bedoeld is als zelfstandig naamwoord (the delay) of als werkwoord (to delay). Wanneer je van het tweede uitgaat zou "wacht" een goede vertaling zijn. En er zou ook wat meer ruimte komen.
Afsluiten na handmatig opslaan of kopiëren:
Het woord "Afsluiten" zou misschien vervangen kunnen worden door "sluit"?
Comment 6 Bug Janitor Service 2023-04-25 21:39:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/234
Comment 7 Nate Graham 2023-04-25 22:54:15 UTC
Git commit 9ef2dcdf477020fd2ba8ecb4f2678e097c75b365 by Nate Graham.
Committed on 25/04/2023 at 22:52.
Pushed by ngraham into branch 'master'.

Hide redundant header on Wayland

On Wayland where screen recording is supported, the right column has a
tab bar on top with the text "Screenshot" and "Recording" for the tabs.

On each of the tabs, right below that tab bar is a header that says a
wordier version of the same thing, which is rather redundant.

Hide the labels on Wayland when the tab bar is visible.
FIXED-IN: 23.04.1

M  +3    -0    src/Gui/CaptureOptions.qml
M  +6    -12   src/Gui/RecordOptions.qml

https://invent.kde.org/graphics/spectacle/commit/9ef2dcdf477020fd2ba8ecb4f2678e097c75b365
Comment 8 Nate Graham 2023-04-25 22:55:00 UTC
Git commit 65027f4bbfd6eb5e169f2dfb65176886dd85dff6 by Nate Graham.
Committed on 25/04/2023 at 22:54.
Pushed by ngraham into branch 'release/23.04'.

Hide redundant header on Wayland

On Wayland where screen recording is supported, the right column has a
tab bar on top with the text "Screenshot" and "Recording" for the tabs.

On each of the tabs, right below that tab bar is a header that says a
wordier version of the same thing, which is rather redundant.

Hide the labels on Wayland when the tab bar is visible.
FIXED-IN: 23.04.1


(cherry picked from commit 9ef2dcdf477020fd2ba8ecb4f2678e097c75b365)

M  +3    -0    src/Gui/CaptureOptions.qml
M  +6    -12   src/Gui/RecordOptions.qml

https://invent.kde.org/graphics/spectacle/commit/65027f4bbfd6eb5e169f2dfb65176886dd85dff6