Bug 468668 - Right-click on un-pinned application in Task Manager that is still displaying its launch feedback inappropriately shows "unpin from Task Manager"
Summary: Right-click on un-pinned application in Task Manager that is still displaying...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: 5.27.4
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-18 21:45 UTC by tomjansen97
Modified: 2023-04-19 17:46 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/40514ae41d79a8584b243bae8d9fe249fc3f5966
Version Fixed In: 5.27.5
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description tomjansen97 2023-04-18 21:45:07 UTC 
SUMMARY
Just as the title says


STEPS TO REPRODUCE
0. Enable Icons-only task manager
1. Start an not-pinned application
2. As application is starting, right click on the icon in the task manager
3. In context menu, it says "unpin from Task Manager"

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 tomjansen97 2023-04-18 21:46:19 UTC 
Operating System: Arch Linux 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.9
Comment 2 Nate Graham 2023-04-19 15:44:12 UTC 
Can reproduce. Probably we should remove this menu item entirely while the app is still loading as it will be in an inconsistent state.
Comment 3 Nate Graham 2023-04-19 17:41:03 UTC 
Looks like it's a simple code bug; will fix it.
Comment 4 Nate Graham 2023-04-19 17:43:22 UTC 
Git commit ab6a7b1ea913e9576b6f465c2fa07c7165ea99f8 by Nate Graham.
Committed on 19/04/2023 at 17:41.
Pushed by ngraham into branch 'master'.

applets/taskmanager: don't show Unpin menu item while app is launching

We already filter out the Pin menu item for launching apps, but doing so
for the Unpin menu item was missed. Showing this menu item makes even
less sense for launching apps, so it appears to have been a simple
omission rather than an intentional design choice.
FIXED-IN: 5.27.5

M  +1    -0    applets/taskmanager/package/contents/ui/ContextMenu.qml

https://invent.kde.org/plasma/plasma-desktop/commit/ab6a7b1ea913e9576b6f465c2fa07c7165ea99f8
Comment 5 Nate Graham 2023-04-19 17:46:06 UTC 
Git commit 40514ae41d79a8584b243bae8d9fe249fc3f5966 by Nate Graham.
Committed on 19/04/2023 at 17:43.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/taskmanager: don't show Unpin menu item while app is launching

We already filter out the Pin menu item for launching apps, but doing so
for the Unpin menu item was missed. Showing this menu item makes even
less sense for launching apps, so it appears to have been a simple
omission rather than an intentional design choice.
FIXED-IN: 5.27.5
(cherry picked from commit ab6a7b1ea913e9576b6f465c2fa07c7165ea99f8)

M  +1    -0    applets/taskmanager/package/contents/ui/ContextMenu.qml

https://invent.kde.org/plasma/plasma-desktop/commit/40514ae41d79a8584b243bae8d9fe249fc3f5966