Bug 468644 - Show track artist and album on the Now Playing view (at least when the header bar and playlist are hidden)
Summary: Show track artist and album on the Now Playing view (at least when the header...
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2023-04-18 11:15 UTC by Jack Hill
Modified: 2024-09-05 16:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 24.08.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-04-18 11:15:19 UTC
SUMMARY
If the header bar and playlist are hidden, then the Now Playing view should show the track artist and album (and probably track name, but that's visible in the window title)

STEPS TO REPRODUCE
1. Reduce the header bar until the track information disappears
2. Open the Now Playing view
3. Hide the playlist

OBSERVED RESULT
No track artist of album

EXPECTED RESULT
Track artist and album

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230416
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.8
Kernel Version: 6.2.10-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-04-19 15:32:32 UTC
Makes sense. We previously removed this information on the basis that was already visible in the header. But now that the header can be collapsed, it makes sense to conditionally re-add it.

Probably doable by showing that metadata when persistentSettings.headerBarHeight is 0.
Comment 2 Unknown 2024-06-28 13:59:01 UTC
Hey! Gonna try to work on this one :D
Comment 3 Bug Janitor Service 2024-09-04 09:42:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/622
Comment 4 Nate Graham 2024-09-05 16:02:00 UTC
Git commit 578dc2687e04074d4fc91676363ba8749d0fb90f by Nate Graham, on behalf of Engin Karakurt.
Committed on 05/09/2024 at 16:01.
Pushed by ngraham into branch 'master'.

Remove filters to hide title, artist, and album from Now Playing view

This way the information is always easily visible to the user, regardless
of parts of the UI being hidden or not.
FIXED-IN: 24.08.1

M  +0    -3    src/models/trackcontextmetadatamodel.cpp

https://invent.kde.org/multimedia/elisa/-/commit/578dc2687e04074d4fc91676363ba8749d0fb90f
Comment 5 Nate Graham 2024-09-05 16:08:46 UTC
Git commit 303cb9b8dd4d0a2275784417c0b32ed693ade495 by Nate Graham.
Committed on 05/09/2024 at 16:03.
Pushed by ngraham into branch 'release/24.08'.

Remove filters to hide title, artist, and album from Now Playing view

This way the information is always easily visible to the user, regardless
of parts of the UI being hidden or not.
FIXED-IN: 24.08.1


(cherry picked from commit 578dc2687e04074d4fc91676363ba8749d0fb90f)

e226bb61 Remove filters to show title, artist & album

Co-authored-by: Engin Karakurt <street4597@proton.me>

M  +0    -3    src/models/trackcontextmetadatamodel.cpp

https://invent.kde.org/multimedia/elisa/-/commit/303cb9b8dd4d0a2275784417c0b32ed693ade495