Bug 468500 - Compilation failed with -DENABLE_MEDIAPLAYER=OFF
Summary: Compilation failed with -DENABLE_MEDIAPLAYER=OFF
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: 8.0.0
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-14 11:38 UTC by nucleo
Modified: 2023-04-15 03:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.1.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nucleo 2023-04-14 11:38:45 UTC
SUMMARY

Compilation of digiKam 8.0.0 failed with -DENABLE_MEDIAPLAYER=OFF

OBSERVED RESULT

/root/rpmbuild/BUILD/digikam-8.0.0/core/utilities/setup/setup.cpp: In destructor 'virtual Digikam::Setup::~Setup()':
/root/rpmbuild/BUILD/digikam-8.0.0/core/utilities/setup/setup.cpp:272:64: error: 'class Digikam::Setup::Private' has no member named 'videoPage'
  272 |     group.writeEntry(QLatin1String("Video Tab"),       (int)d->videoPage->activeTab());
      |                                                                ^~~~~~~~~
/root/rpmbuild/BUILD/digikam-8.0.0/core/utilities/setup/setup.cpp: In member function 'void Digikam::Setup::showPage(Page)':
/root/rpmbuild/BUILD/digikam-8.0.0/core/utilities/setup/setup.cpp:580:12: error: 'class Digikam::Setup::Private' has no member named 'videoPage'
  580 |         d->videoPage->setActiveTab((SetupVideo::VideoTab)group.readEntry(QLatin1String("Video Tab"), (int)SetupVideo::Decoder));
      |            ^~~~~~~~~
/root/rpmbuild/BUILD/digikam-8.0.0/core/utilities/setup/setup.cpp:580:37: error: 'SetupVideo' has not been declared
  580 |         d->videoPage->setActiveTab((SetupVideo::VideoTab)group.readEntry(QLatin1String("Video Tab"), (int)SetupVideo::Decoder));
      |                                     ^~~~~~~~~~


SOFTWARE/OS VERSIONS
Fedora 37
FFmpeg 5.1.3
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION

Compilation for Fedora with -DENABLE_MEDIAPLAYER=ON succeeded but digiKam crashes in MediaPlayer, so maybe the only solution to avoid crash is disable MediaPlayer because only ffmpeg 5 available in Fedora repository
https://bugs.kde.org/show_bug.cgi?id=468480
Comment 1 Maik Qualmann 2023-04-14 17:50:13 UTC
Git commit 344daea1d9a54d8b7212671303e721d43047f08a by Maik Qualmann.
Committed on 14/04/2023 at 17:48.
Pushed by mqualmann into branch 'master'.

fix compile with -DENABLE_MEDIAPLAYER=OFF
FIXED-IN: 8.1.0

M  +2    -1    NEWS
M  +28   -0    core/utilities/setup/setup.cpp
M  +4    -0    core/utilities/setup/setup.h

https://invent.kde.org/graphics/digikam/commit/344daea1d9a54d8b7212671303e721d43047f08a
Comment 2 nucleo 2023-04-14 22:41:15 UTC
With patch no previous error but new one

/root/rpmbuild/BUILD/digikam-8.0.0/core/dplugins/generic/view/slideshow/common/slideshowloader.cpp: In constructor 'DigikamGenericSlideShowPlugin::SlideShowLoader::SlideShowLoader(DigikamGenericSlideShowPlugin::SlideShowSettings*)':
/root/rpmbuild/BUILD/digikam-8.0.0/core/dplugins/generic/view/slideshow/common/slideshowloader.cpp:180:8: error: 'class DigikamGenericSlideShowPlugin::SlideShowLoader::Private' has no member named 'videoView'
  180 |     d->videoView->installEventFilter(this);
      |        ^~~~~~~~~
Comment 3 caulier.gilles 2023-04-15 03:40:08 UTC
Git commit eaa636eec1b8d17c552b6d557720f8b5c479607f by Gilles Caulier.
Committed on 15/04/2023 at 03:39.
Pushed by cgilles into branch 'master'.

Fix broken compilation in slideshow tool if no media player

M  +7    -2    core/dplugins/generic/view/slideshow/common/slideshowloader.cpp
M  +1    -1    core/dplugins/generic/view/slideshow/common/slideshowloader.h

https://invent.kde.org/graphics/digikam/commit/eaa636eec1b8d17c552b6d557720f8b5c479607f
Comment 4 caulier.gilles 2023-04-15 03:51:23 UTC
Compilation is fixed now.