Bug 468459 - After running a partial update, the "select all" and "select none" buttons are not shown
Summary: After running a partial update, the "select all" and "select none" buttons ar...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.27.4
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-13 08:17 UTC by Oded Arbel
Modified: 2023-04-14 23:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
A screenshot showing the problem (160.82 KB, image/png)
2023-04-13 08:18 UTC, Oded Arbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oded Arbel 2023-04-13 08:17:45 UTC
SUMMARY
When first going to the "Update" section in discover, the footer of the update list features two buttons "Select All" and "Select None" that can be used to manipulate the selected updates, as well as a sum of the total size of the updates. After installing only some of the updates, when the list of updates is shown again, the buttons are not shown, instead the footer only shows a checkbox labeled "Restart automatically after update has completed".

STEPS TO REPRODUCE
1. Start discover and go to the "Updates" section.
2. Verify that more than one update is available.
3. Click "Select None" and then check one update to be installed and click "".
4. Wait for the update to finish.

OBSERVED RESULT
When the list of Updates shows again, the "Select All" and "Select None" buttons are missing.

EXPECTED RESULT
The option to unselect all updates should still be available.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
During the update process itself, the footer changes to show a checkbox labeled "Restart automatically after update has completed" - and this remains after the update process completes. The issue is probably that the footer is not being returned to the "list possible updates" mode after, as needed, after it was changed to the "during updates" mode.
Comment 1 Oded Arbel 2023-04-13 08:18:35 UTC
Created attachment 158063 [details]
A screenshot showing the problem
Comment 2 Bug Janitor Service 2023-04-14 01:45:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/537
Comment 3 Aleix Pol 2023-04-14 23:39:22 UTC
Git commit 2e134322179048f746cb8b730c6f30a44cd3892d by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 14/04/2023 at 23:27.
Pushed by apol into branch 'Plasma/5.27'.

updates ui: Simplify bottom toolbar logic

Only show the select buttons when not updating. Only show the reboot
checkbox while updating.

M  +5    -5    discover/qml/UpdatesPage.qml

https://invent.kde.org/plasma/discover/commit/2e134322179048f746cb8b730c6f30a44cd3892d
Comment 4 Aleix Pol 2023-04-14 23:39:57 UTC
Git commit 16b3aace04d40291d90a9a56de488364db9f2a93 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 14/04/2023 at 23:39.
Pushed by apol into branch 'master'.

updates ui: Simplify bottom toolbar logic

Only show the select buttons when not updating. Only show the reboot
checkbox while updating.


(cherry picked from commit 2e134322179048f746cb8b730c6f30a44cd3892d)

M  +5    -5    discover/qml/UpdatesPage.qml

https://invent.kde.org/plasma/discover/commit/16b3aace04d40291d90a9a56de488364db9f2a93