Created attachment 157859 [details] Screenshot of behavior SUMMARY Any search with the rpm-ostree backend enabled seems to always include the current deployments near the top of the list, whether the search has to do with OS terms or not. STEPS TO REPRODUCE 1. Start from Discover home 2. Search for anything, even non-existent packages or gibberish OBSERVED RESULT The current deployments appear as results to the search, despite not having any relation to the search. EXPECTED RESULT Programs/deployments that do not have relevance to the search do not appear in the search results. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora Linux 37 Kinoite KDE Plasma Version: 5.27.3 KDE Frameworks Version: 5.104.0 Qt Version: 5.15.8 ADDITIONAL INFORMATION None
(In reply to Bailey Hollis from comment #0) > Created attachment 157859 [details] > Screenshot of behavior > > SUMMARY > Any search with the rpm-ostree backend enabled seems to always include the > current deployments near the top of the list, whether the search has to do > with OS terms or not. > > STEPS TO REPRODUCE > 1. Start from Discover home > 2. Search for anything, even non-existent packages or gibberish > > OBSERVED RESULT > The current deployments appear as results to the search, despite not having > any relation to the search. > > EXPECTED RESULT > Programs/deployments that do not have relevance to the search do not appear > in the search results. > > SOFTWARE/OS VERSIONS > Linux/KDE Plasma: > Fedora Linux 37 Kinoite > KDE Plasma Version: 5.27.3 > KDE Frameworks Version: 5.104.0 > Qt Version: 5.15.8 > > ADDITIONAL INFORMATION > None Hmm. The behavior seems to be gone now.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/536
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/538
Git commit 7bd3ba098ca97a01ba01f9d0fadd6522136aa67e by Timothée Ravier. Committed on 18/04/2023 at 17:40. Pushed by ravier into branch 'master'. rpm-ostree: Do not offer resources when the search doesn't pertain M +8 -0 libdiscover/backends/RpmOstreeBackend/RpmOstreeBackend.cpp https://invent.kde.org/plasma/discover/commit/7bd3ba098ca97a01ba01f9d0fadd6522136aa67e
Wow, thanks for the speedy work!
Git commit 1756b3a8ac7b66fd1c93a823e6dde262d1f2a9ec by Aleix Pol Gonzalez, on behalf of Timothée Ravier. Committed on 19/04/2023 at 17:00. Pushed by ravier into branch 'Plasma/5.27'. rpm-ostree: Do not offer resources when the search doesn't pertain Added Category include to fix build. Co-authored with: Aleix Pol <aleixpol@kde.org> Cherry-picked from: 7bd3ba098ca97a01ba01f9d0fadd6522136aa67e M +9 -0 libdiscover/backends/RpmOstreeBackend/RpmOstreeBackend.cpp https://invent.kde.org/plasma/discover/commit/1756b3a8ac7b66fd1c93a823e6dde262d1f2a9ec
Git commit 99608546ed8da4928792068210dee4c43a6f4522 by Timothée Ravier. Committed on 25/07/2023 at 18:00. Pushed by ravier into branch 'master'. rpm-ostree: Improve search and filter logic More complete fix for https://bugs.kde.org/show_bug.cgi?id=468162 Whitespace at the beginning and the end of search keyword is usually not relevant for the search field so trim it. See also: https://bugs.kde.org/show_bug.cgi?id=470372 M +15 -3 libdiscover/backends/RpmOstreeBackend/RpmOstreeBackend.cpp https://invent.kde.org/plasma/discover/-/commit/99608546ed8da4928792068210dee4c43a6f4522
Git commit a3c5cd250b0a8aa436ff1b5f43a5aa11b651308b by Timothée Ravier. Committed on 25/07/2023 at 18:00. Pushed by ravier into branch 'Plasma/5.27'. rpm-ostree: Improve search and filter logic More complete fix for https://bugs.kde.org/show_bug.cgi?id=468162 Whitespace at the beginning and the end of search keyword is usually not relevant for the search field so trim it. See also: https://bugs.kde.org/show_bug.cgi?id=470372 Cherry picked from: https://invent.kde.org/plasma/discover/-/merge_requests/575 M +15 -3 libdiscover/backends/RpmOstreeBackend/RpmOstreeBackend.cpp https://invent.kde.org/plasma/discover/-/commit/a3c5cd250b0a8aa436ff1b5f43a5aa11b651308b