Bug 468077 - It's now harder to draw an unfilled circle/ellipse/square/rectangle
Summary: It's now harder to draw an unfilled circle/ellipse/square/rectangle
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (other bugs)
Version First Reported In: 23.03.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: regression, usability
: 469592 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-04-02 14:34 UTC by Patrick Silva
Modified: 2023-05-28 10:31 UTC (History)
13 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
where to set opacity (51.70 KB, image/png)
2023-04-03 16:39 UTC, Noah Davis
Details
Use a heckbox to control the usage of fil (561.90 KB, image/gif)
2023-05-03 21:13 UTC, Stefan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-04-02 14:34:40 UTC
STEPS TO REPRODUCE
1.  open Spectacle by pressing printscreen key
2. click on "Show annotation tools" button on top
3. try to highlight something in the screenshot with a unfilled circle/ellipse/square/rectangle

OBSERVED RESULT
we can't draw a unfilled circle/ellipse/square/rectangle anymore

EXPECTED RESULT
we can draw a unfilled circle/ellipse/square/rectangle like in Spectacle 22.12.3

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Comment 1 Noah Davis 2023-04-03 08:31:41 UTC
> we can't draw a unfilled circle/ellipse/square/rectangle anymore

You mean a rectangle/ellipse outline? It could be more convenient, but you can currently do that by setting the fill opacity to 0 and disabling the shadow.
Comment 2 Patrick Silva 2023-04-03 15:59:26 UTC
(In reply to Noah Davis from comment #1)
> > we can't draw a unfilled circle/ellipse/square/rectangle anymore
> 
> You mean a rectangle/ellipse outline? It could be more convenient, but you
> can currently do that by setting the fill opacity to 0 and disabling the
> shadow.

Can you tell me how to set the fill opacity to 0 please?
Comment 3 Noah Davis 2023-04-03 16:39:33 UTC
Created attachment 157820 [details]
where to set opacity
Comment 4 Noah Davis 2023-04-03 16:40:26 UTC
A better color picker would probably also help
Comment 5 Patrick Silva 2023-04-03 16:44:29 UTC
Thanks. I want to highlight things like the ones highlighted in green and red in the following screenshot:

https://bugsfiles.kde.org/attachment.cgi?id=157791
Comment 6 Noah Davis 2023-04-03 16:49:20 UTC
Maybe we ought to have checkboxes for fill and stroke so that disabling them becomes more convenient and obvious
Comment 7 Nate Graham 2023-04-03 20:13:44 UTC
That seems like a good idea.
Comment 8 Stefan 2023-05-03 21:13:44 UTC
Created attachment 158673 [details]
Use a heckbox to control the usage of fil
Comment 9 Stefan 2023-05-03 21:14:13 UTC
I miss that a lot, too. I am not that experienced in … all this stuff :-)  ... but also interested.

First try: https://invent.kde.org/hotzeplotz/spectacle/-/tree/optional-fill-color

See Attachment for current state. https://bugs.kde.org/attachment.cgi?id=158673

If this is something usable, I'd love to finish it. But would need some guidance, review and advice. Would that be possible?
Comment 10 Thiago Sueto 2023-05-04 01:48:22 UTC
(In reply to Stefan from comment #9)
> If this is something usable, I'd love to finish it. But would need some
> guidance, review and advice. Would that be possible?

Hello Stefan, just send an MR to the Spectacle project. :)

This way

* other people will know there's someone working on this
* the other devs can better assist you by reviewing the code
Comment 11 Nate Graham 2023-05-05 06:14:34 UTC
What we should probably do in the short term is default to "no fill" for these shapes, and fix the bug that when there's no fill, the background isn't 100% visually transparent but rather has a light gray overlay.
Comment 12 Bug Janitor Service 2023-05-05 09:00:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/236
Comment 13 Bug Janitor Service 2023-05-05 10:02:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/237
Comment 14 Noah Davis 2023-05-05 15:26:12 UTC
Git commit 8a9540083b1024fb30f93b0d0e250574459a2f8a by Noah Davis.
Committed on 05/05/2023 at 10:07.
Pushed by ndavis into branch 'master'.

Use transparent default fill color for rectangle and ellipse annotations

M  +2    -2    src/Gui/SettingsDialog/spectacle.kcfg

https://invent.kde.org/graphics/spectacle/commit/8a9540083b1024fb30f93b0d0e250574459a2f8a
Comment 15 Noah Davis 2023-05-05 15:26:20 UTC
Git commit fa56462fac97b81887fc91fcb1eaa94a815bded0 by Noah Davis.
Committed on 05/05/2023 at 10:07.
Pushed by ndavis into branch 'master'.

Allow making annotation colors fully transparent via checkboxes

M  +24   -12   src/Gui/AnnotationOptionsToolBarContents.qml

https://invent.kde.org/graphics/spectacle/commit/fa56462fac97b81887fc91fcb1eaa94a815bded0
Comment 16 Noah Davis 2023-05-05 15:28:07 UTC
Git commit f2e9ff1ffb013af7381dba8bcf9c254f519be38b by Noah Davis.
Committed on 05/05/2023 at 15:28.
Pushed by ndavis into branch 'release/23.04'.

Allow making annotation colors fully transparent via checkboxes


(cherry picked from commit fa56462fac97b81887fc91fcb1eaa94a815bded0)

M  +24   -12   src/Gui/AnnotationOptionsToolBarContents.qml

https://invent.kde.org/graphics/spectacle/commit/f2e9ff1ffb013af7381dba8bcf9c254f519be38b
Comment 17 Noah Davis 2023-05-05 15:28:21 UTC
Git commit 09700b7f5dd23ed5355954a0727a75c188931906 by Noah Davis.
Committed on 05/05/2023 at 15:28.
Pushed by ndavis into branch 'release/23.04'.

Use transparent default fill color for rectangle and ellipse annotations


(cherry picked from commit 8a9540083b1024fb30f93b0d0e250574459a2f8a)

M  +2    -2    src/Gui/SettingsDialog/spectacle.kcfg

https://invent.kde.org/graphics/spectacle/commit/09700b7f5dd23ed5355954a0727a75c188931906
Comment 18 Patrick Silva 2023-05-10 21:51:50 UTC
*** Bug 469592 has been marked as a duplicate of this bug. ***