Bug 468013 - Volume/brightness OSDs do not display localised percent value for Turkish
Summary: Volume/brightness OSDs do not display localised percent value for Turkish
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.27.3
Platform: Other Other
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-31 21:18 UTC by Emir SARI
Modified: 2023-04-04 21:34 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.5
Sentry Crash Report:


Attachments
screenshot (1.57 MB, image/png)
2023-03-31 21:18 UTC, Emir SARI
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2023-03-31 21:18:45 UTC
Created attachment 157750 [details]
screenshot

See screenshot.

In Turkish, the correct percent formatting is %36, as seen in the volume tray applet. However, the OSD still displays the standard format, which is 36%. Both strings are translated for some time.

Code for the percentage value is here: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/lookandfeel/org.kde.breeze/contents/osd/OsdItem.qml#L80

Plasma 5.27.3, tr_TR locale.
Comment 1 Nate Graham 2023-04-04 18:56:59 UTC
Hmm, as far as I can see, the code is correct here.
Comment 2 Bug Janitor Service 2023-04-04 20:37:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2795
Comment 3 Ismael Asensio 2023-04-04 21:10:40 UTC
Git commit 70a6f2d1d9f30a1fc45bd1a60423a1a8c2ad4a85 by Ismael Asensio.
Committed on 04/04/2023 at 20:24.
Pushed by iasensio into branch 'master'.

lookandfeel/osd: Explicitely add the translation domain

This is required for the theme contents so the engine effectively
finds the suitable translation
FIXED-IN: 5.27.5

M  +2    -2    lookandfeel/org.kde.breeze/contents/osd/OsdItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/70a6f2d1d9f30a1fc45bd1a60423a1a8c2ad4a85
Comment 4 Ismael Asensio 2023-04-04 21:34:20 UTC
Git commit 4467cf391b136c0692843973f48c88833241d3a0 by Ismael Asensio.
Committed on 04/04/2023 at 21:11.
Pushed by iasensio into branch 'Plasma/5.27'.

lookandfeel/osd: Explicitely add the translation domain

This is required for the theme contents so the engine effectively
finds the suitable translation
FIXED-IN: 5.27.5


(cherry picked from commit 70a6f2d1d9f30a1fc45bd1a60423a1a8c2ad4a85)

M  +2    -2    lookandfeel/org.kde.breeze/contents/osd/OsdItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/4467cf391b136c0692843973f48c88833241d3a0