Bug 467969 - Canvas gestures do not work in WinInk tablet mode
Summary: Canvas gestures do not work in WinInk tablet mode
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tablets (tablet issues are only very rarely bugs in Krita!) (show other bugs)
Version: git master (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2023-03-30 13:26 UTC by Dmitry Kazakov
Modified: 2023-04-04 14:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kazakov 2023-03-30 13:26:32 UTC 
After updating Qt to Qt 5.15 tablet gestures stopped working properly in WinInk mode

0) Switch on WinInk mode
1) Press Ctrl key for the color picker
2) Start a stroke
3) Release Ctrl key
4) Stop the stroke

BUG: Krita still thinks that Ctrl key is pressed, so the color picking continues

It seems like there is some bug with filling the modifiers() property of the tablet events, which makes KisShortcutsMatcher confused about the status of the keyboard.

Tested on:

1) Win11 + Wacom 5 + WinInk mode
2) Win10 + Lenovo Yoga + Embedded tablet + WinInk mode

On both test systems, the issue doesn't exist in WinTab mode.
Comment 1 Halla Rempt 2023-03-30 13:50:31 UTC 
I guess there's something I'm missing here, on all systems I've tried (wintab, winink, linux/x11 and macos) the behaviour is the same: the color picking only stops when you lift the stylus, and the next stroke with paint with the last picked color. I think it's always been that way?
Comment 2 Dmitry Kazakov 2023-04-04 14:19:05 UTC 
The bug is fixed in https://invent.kde.org/szaman/qtbase/-/commit/39ed657b6393c850735857e367303800f1a04413

(it was a regression of an update to Qt 5.15)