Bug 467924 - Match English text as well as translated text
Summary: Match English text as well as translated text
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords:
: 473886 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-29 13:52 UTC by Emir SARI
Modified: 2023-09-21 16:42 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2023-03-29 13:52:02 UTC
Steps:
1. Install a KDE app with a localised name, like KMail (K Posta in Turkish (tr_TR)
2. Open KRunner or Application menu
3. Type KMail

Expected:
1. K Posta application with its subtext should be visible

Actual:
1. Only "Run kmail" is visible

The shell command is confusing at first sight. Reported by the community. This works for the default set of applications, like System Monitor.
Comment 1 Nate Graham 2023-08-29 19:30:51 UTC
*** Bug 473886 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2023-09-01 15:16:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kservice/-/merge_requests/157
Comment 3 Alexander Lohnau 2023-09-07 18:48:54 UTC
Git commit 6d5956a322db1029eb8d7a09b0bef94391408ea5 by Alexander Lohnau.
Committed on 06/09/2023 at 21:49.
Pushed by cullmann into branch 'master'.

KService: Add method to get untranslated name

Store this and the untranslated generic name as member variables, because it will speed up the lookup.
We also don't have as many member variables that one might consider them getting messy.

M  +30   -2    autotests/kservicetest.cpp
M  +1    -0    autotests/kservicetest.h
A  +7    -0    autotests/org.kde.testnames.desktop
M  +18   -8    src/services/kservice.cpp
M  +8    -2    src/services/kservice.h
M  +2    -0    src/services/kservice_p.h

https://invent.kde.org/frameworks/kservice/-/commit/6d5956a322db1029eb8d7a09b0bef94391408ea5
Comment 4 Bug Janitor Service 2023-09-20 06:29:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3311
Comment 5 Alexander Lohnau 2023-09-21 16:42:33 UTC
Git commit d951141c291ed0e74459d9ade08bb12bfbcaa324 by Alexander Lohnau.
Committed on 21/09/2023 at 18:41.
Pushed by alex into branch 'master'.

runners/services: Check untranslatedName when matching services
FIXED-IN: 6.0

M  +5    -1    runners/services/servicerunner.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/d951141c291ed0e74459d9ade08bb12bfbcaa324