Bug 467912 - Image Editor ignores former window size at startup
Summary: Image Editor ignores former window size at startup
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Ergonomy (other bugs)
Version First Reported In: 8.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-29 02:08 UTC by Tom Cunningham
Modified: 2023-04-07 12:45 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 8.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Cunningham 2023-03-29 02:08:49 UTC
SUMMARY
The Image Editor window always starts small when digiKam is first started, even though it was full-screen previously.
***


STEPS TO REPRODUCE
1. Start digiKam.
2. Start the Image Editor.
3. Maximize Image Editor window.
4. Exit Image Editor.
5. Exit digiKam.
6. Start digiKam.
7. Start Image Editor.


OBSERVED RESULT
Image Editor window is small.

EXPECTED RESULT
Image Editor window is full-screen.

SOFTWARE/OS VERSIONS
Windows: 11
Comment 1 Maik Qualmann 2023-03-29 10:29:58 UTC
Git commit c5d75ef443ac7b5c8691834c80e7d8a0cd0343cd by Maik Qualmann.
Committed on 29/03/2023 at 10:29.
Pushed by mqualmann into branch 'master'.

add config header to fix compile switch for Windows

M  +1    -0    core/libs/widgets/mainview/dxmlguiwindow_p.h

https://invent.kde.org/graphics/digikam/commit/c5d75ef443ac7b5c8691834c80e7d8a0cd0343cd
Comment 2 Maik Qualmann 2023-03-29 19:23:27 UTC
Git commit 0c8aa2cddc36e7e08b103574e440e363020a065e by Maik Qualmann.
Committed on 29/03/2023 at 19:22.
Pushed by mqualmann into branch 'master'.

try with disabled workaround for the KXMLGui
The issue may have been resolved in the KF5 API.

M  +10   -8    core/libs/widgets/mainview/dxmlguiwindow.cpp

https://invent.kde.org/graphics/digikam/commit/0c8aa2cddc36e7e08b103574e440e363020a065e
Comment 3 Maik Qualmann 2023-03-30 19:26:39 UTC
Git commit 1a2eee5c7c7d90bad59beb2f0a093f8399b48b0a by Maik Qualmann.
Committed on 30/03/2023 at 19:25.
Pushed by mqualmann into branch 'master'.

next try to fix window size

M  +10   -12   core/libs/widgets/mainview/dxmlguiwindow.cpp

https://invent.kde.org/graphics/digikam/commit/1a2eee5c7c7d90bad59beb2f0a093f8399b48b0a
Comment 4 Maik Qualmann 2023-04-04 18:00:01 UTC
Git commit 58951fec3f56d327d3ef2e981f460366f2e20508 by Maik Qualmann.
Committed on 04/04/2023 at 17:59.
Pushed by mqualmann into branch 'master'.

next try to fix window size #2

M  +2    -0    core/app/main/digikamapp.cpp
M  +0    -16   core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +0    -5    core/libs/widgets/mainview/dxmlguiwindow.h
M  +2    -1    core/utilities/imageeditor/editor/editorwindow.cpp
M  +2    -0    core/utilities/import/main/importui.cpp
M  +2    -0    core/utilities/lighttable/lighttablewindow.cpp
M  +2    -0    core/utilities/queuemanager/main/queuemgrwindow.cpp

https://invent.kde.org/graphics/digikam/commit/58951fec3f56d327d3ef2e981f460366f2e20508
Comment 5 Maik Qualmann 2023-04-05 21:08:32 UTC
Git commit 303f96df39fc1f9a3ce0755d08d7a641bb2f2739 by Maik Qualmann.
Committed on 05/04/2023 at 21:07.
Pushed by mqualmann into branch 'master'.

next try to fix window size #3

M  +1    -1    core/app/main/digikamapp_setup.cpp
M  +0    -18   core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +0    -5    core/libs/widgets/mainview/dxmlguiwindow.h
M  +3    -1    core/utilities/imageeditor/main/imagewindow.cpp
M  +1    -1    core/utilities/imageeditor/main/imagewindow.h
M  +3    -1    core/utilities/lighttable/lighttablewindow.cpp
M  +1    -1    core/utilities/lighttable/lighttablewindow.h

https://invent.kde.org/graphics/digikam/commit/303f96df39fc1f9a3ce0755d08d7a641bb2f2739
Comment 6 Maik Qualmann 2023-04-07 08:28:31 UTC
Git commit 8b7a6bc94980fdb1cf24f82e18923df7aa380d31 by Maik Qualmann.
Committed on 07/04/2023 at 08:27.
Pushed by mqualmann into branch 'master'.

next try to fix window size #4

M  +51   -5    core/libs/widgets/mainview/dxmlguiwindow.cpp
M  +7    -1    core/libs/widgets/mainview/dxmlguiwindow.h

https://invent.kde.org/graphics/digikam/commit/8b7a6bc94980fdb1cf24f82e18923df7aa380d31
Comment 7 Maik Qualmann 2023-04-07 10:37:38 UTC
Problem is now fixed on Windows. Tested with today's nightly MSVC digiKam build.

Maik
Comment 8 Tom Cunningham 2023-04-07 12:41:59 UTC
(In reply to Maik Qualmann from comment #7)
> Problem is now fixed on Windows. Tested with today's nightly MSVC digiKam
> build.
> 
> Maik

Tried with digiKam-8.0.0-20230407T040812-Win64-debug.exe, still doesn't work.
Comment 9 caulier.gilles 2023-04-07 12:45:16 UTC
Wait a little bit, i needs to rebuild the Windows installer with last Maik changes

Gilles