Bug 467857 - Inconsistent drag-from-empty-areas-of-toolbar behavior in Discover
Summary: Inconsistent drag-from-empty-areas-of-toolbar behavior in Discover
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.104.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-27 18:44 UTC by Connor Carney
Modified: 2023-04-05 13:41 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.105


Attachments
list vs layout toolbar behavior (686 bytes, text/x-qml)
2023-04-05 01:27 UTC, Connor Carney
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Connor Carney 2023-03-27 18:44:58 UTC
SUMMARY
When the breeze theme is configured to allow dragging windows by the toolbar, the home and application detail pages support toolbar dragging, while the category and search result pages do not.  

This is particularly an issue in multi-column mode: the toolbars in the list and detail panes are visually continuous, but can only be dragged from the detail side.

(More generally, dragging by the toolbar doesn't work on pages where the content item is a list view)

STEPS TO REPRODUCE
1. In system settings > Application Style > Configure Breeze, make sure the Window Drag Mode is set to "Titlebar, Menu Bars and Toolbars" or "All Empty Areas" (this is the default setting)
2. Launch discover, enter a search term, and select an application from the search results
3. Resize the window so that both the search results and the application details are visible in the window
4. Attempt to drag the window by the toolbar above each pane

OBSERVED RESULT
The window can be dragged by the toolbar on the application detail side, but not on the search result side.

EXPECTED RESULT
The window should be draggable by both sides of the toolbar (or, failing that, by neither side of the toolbar; the behavior should be consistent).

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 22.10 with KDE 5 from source
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.6
Comment 1 Aleix Pol 2023-03-28 01:02:23 UTC
Discover doesn't have a toolbar though. Moving to Kirigami as it's responsible for the component you are referring to.
Comment 2 Nate Graham 2023-04-05 00:33:04 UTC
That header bar on top under the titlebar is the toolbar. I can reproduce the fact that on some pages it's draggable, and on some pages it's not. This suggests that it may actually be an implementation issue in Discover rather than a general problem in Kirigami. That said, I can't find a pattern here:

Draggable-toolbar pages:
- Home/Featured
- App details
- About

Non-draggable-toolbar pages:
- Apps list/Search results
- Installed
- Settings
- Updates
Comment 3 Connor Carney 2023-04-05 01:27:09 UTC
Created attachment 157857 [details]
list vs layout toolbar behavior

I think that the pattern there is something like "pages where the main item is a ListView" which I can reproduce with this minimal example.
Comment 4 Bug Janitor Service 2023-04-05 09:50:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1021
Comment 5 Marco Martin 2023-04-05 10:05:28 UTC
Git commit dc4f730a80a087d32c63d4af23ae4e66a7bec62a by Marco Martin.
Committed on 05/04/2023 at 10:05.
Pushed by mart into branch 'master'.

fix dragging from toolbar

scrollingArea, the main child of the contentitem when not in itemview
mode,
was haging invisible over the toolbar when in itemview mode, making it
eat mouse events

M  +2    -0    src/controls/ScrollablePage.qml

https://invent.kde.org/frameworks/kirigami/commit/dc4f730a80a087d32c63d4af23ae4e66a7bec62a
Comment 6 Marco Martin 2023-04-05 10:07:26 UTC
Git commit ca527f2b8aa98987e9235633d68480ed68eb77e3 by Marco Martin.
Committed on 05/04/2023 at 10:07.
Pushed by mart into branch 'kf5'.

fix dragging from toolbar

scrollingArea, the main child of the contentitem when not in itemview
mode,
was haging invisible over the toolbar when in itemview mode, making it
eat mouse events

M  +2    -0    src/controls/ScrollablePage.qml

https://invent.kde.org/frameworks/kirigami/commit/ca527f2b8aa98987e9235633d68480ed68eb77e3